* bugs in net/ipv6/mcast.c (fwd)
@ 2003-10-25 19:27 Pekka Savola
2003-10-27 2:07 ` YOSHIFUJI Hideaki / 吉藤英明
0 siblings, 1 reply; 3+ messages in thread
From: Pekka Savola @ 2003-10-25 19:27 UTC (permalink / raw)
To: netdev; +Cc: Ed Rupp
Probably fixed already, but just in case...
---------- Forwarded message ----------
Date: Sat, 25 Oct 2003 07:23:53 -0500
From: Ed Rupp <niteowl@austin.rr.com>
To: pekkas@netcore.fi
Subject: bugs in net/ipv6/mcast.c
Hi. In the latest linux-2.6.0-test8 source there are 2 bugs in
net/ipv6/mcast.c
In function inet6_mc_check() the if statements on lines 607 and 609 have
extra semicolons that will cause the code to fail.
if (mc->sfmode == MCAST_INCLUDE && i >= psl->sl_count);
rv = 0;
if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count);
rv = 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bugs in net/ipv6/mcast.c (fwd)
2003-10-25 19:27 bugs in net/ipv6/mcast.c (fwd) Pekka Savola
@ 2003-10-27 2:07 ` YOSHIFUJI Hideaki / 吉藤英明
2003-10-27 8:02 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2003-10-27 2:07 UTC (permalink / raw)
To: davem; +Cc: netdev, niteowl, pekkas, yoshfuji
In article <Pine.LNX.4.44.0310252226470.12162-100000@netcore.fi> (at Sat, 25 Oct 2003 22:27:27 +0300 (EEST)), Pekka Savola <pekkas@netcore.fi> says:
> Probably fixed already, but just in case...
Not yet in the bk tree.
> Hi. In the latest linux-2.6.0-test8 source there are 2 bugs in
> net/ipv6/mcast.c
> In function inet6_mc_check() the if statements on lines 607 and 609 have
> extra semicolons that will cause the code to fail.
>
> if (mc->sfmode == MCAST_INCLUDE && i >= psl->sl_count);
> rv = 0;
> if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count);
> rv = 0;
Exactly. Patch follows.
===== net/ipv6/mcast.c 1.39 vs edited =====
--- 1.39/net/ipv6/mcast.c Fri Oct 17 17:05:20 2003
+++ edited/net/ipv6/mcast.c Mon Oct 27 11:01:27 2003
@@ -604,9 +604,9 @@
if (ipv6_addr_cmp(&psl->sl_addr[i], src_addr) == 0)
break;
}
- if (mc->sfmode == MCAST_INCLUDE && i >= psl->sl_count);
+ if (mc->sfmode == MCAST_INCLUDE && i >= psl->sl_count)
rv = 0;
- if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count);
+ if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count)
rv = 0;
}
read_unlock(&ipv6_sk_mc_lock);
--
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bugs in net/ipv6/mcast.c (fwd)
2003-10-27 2:07 ` YOSHIFUJI Hideaki / 吉藤英明
@ 2003-10-27 8:02 ` David S. Miller
0 siblings, 0 replies; 3+ messages in thread
From: David S. Miller @ 2003-10-27 8:02 UTC (permalink / raw)
To: YOSHIFUJI Hideaki / _$B5HF#1QL@; +Cc: netdev, niteowl, pekkas, yoshfuji
On Mon, 27 Oct 2003 11:07:10 +0900 (JST)
YOSHIFUJI Hideaki / _$B5HF#1QL@ <yoshfuji@linux-ipv6.org> wrote:
> Exactly. Patch follows.
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-10-27 8:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-25 19:27 bugs in net/ipv6/mcast.c (fwd) Pekka Savola
2003-10-27 2:07 ` YOSHIFUJI Hideaki / 吉藤英明
2003-10-27 8:02 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).