netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: "David S. Miller" <davem@redhat.com>
Cc: Joe Perches <joe@perches.com>, netdev@oss.sgi.com
Subject: Re: [IPX]: Fix checksum computation.
Date: Fri, 31 Oct 2003 14:21:31 -0800	[thread overview]
Message-ID: <20031031142131.07176dd7.shemminger@osdl.org> (raw)
In-Reply-To: <20031031135328.2a997f6a.davem@redhat.com>

On Fri, 31 Oct 2003 13:53:28 -0800
"David S. Miller" <davem@redhat.com> wrote:

> On Fri, 31 Oct 2003 13:50:04 -0800
> Joe Perches <joe@perches.com> wrote:
> 
> > Was an old NG Sniffer being used to verify this?
> > Sniffer had a long term problem with IPX checksums.
> 
> No, Arnaldo would verify the checksum by running the
> old code and the new code, they produced different
> checksums on every sendmsg() call.
> 
> He then tested it further by making sure he could use
> netatalk successfully between a 2.4.x Linux appletalk
> box and a 2.6.x system with the checksum patch applied.
> Without the patch the 2.4.x system would reject all packets
> sent by the 2.6.x box.
>

Actually, the before the "optimization" went in I did testing between
old 2.4.x and 2.6.x as well as standalone comparisons.  The problem is
a compiler screwup, that probably isn't worth investigating further.

  reply	other threads:[~2003-10-31 22:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200310312006.h9VK62Hh005910@hera.kernel.org>
2003-10-31 21:24 ` [IPX]: Fix checksum computation Joe Perches
2003-10-31 21:23   ` David S. Miller
2003-10-31 21:34     ` Arnaldo Carvalho de Melo
2003-10-31 21:50     ` Joe Perches
2003-10-31 21:53       ` David S. Miller
2003-10-31 22:21         ` Stephen Hemminger [this message]
2003-10-31 22:46           ` Arnaldo Carvalho de Melo
2003-11-01  0:25           ` David S. Miller
2003-10-31 21:56       ` Arnaldo Carvalho de Melo
2003-10-31 23:29     ` Mark Huth
2003-11-01  0:31       ` Joe Perches
2003-11-01  0:31         ` David S. Miller
2003-10-31 21:31   ` Arnaldo Carvalho de Melo
2003-11-01  0:38     ` Stephen Hemminger
2003-11-01  1:13       ` Arnaldo Carvalho de Melo
2003-11-01  1:19         ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031031142131.07176dd7.shemminger@osdl.org \
    --to=shemminger@osdl.org \
    --cc=davem@redhat.com \
    --cc=joe@perches.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).