From: "David S. Miller" <davem@redhat.com>
To: Krishna Kumar <kumarkr@us.ibm.com>
Cc: shemminger@osdl.org, krkumar@us.ibm.com, netdev@oss.sgi.com
Subject: Re: [PATCH] panic during unregister_netdevice()
Date: Thu, 6 Nov 2003 11:59:35 -0800 [thread overview]
Message-ID: <20031106115935.0cd56745.davem@redhat.com> (raw)
In-Reply-To: <OF5A6B1679.D88C275D-ON88256DD6.006CF971@us.ibm.com>
On Thu, 6 Nov 2003 11:58:24 -0800
Krishna Kumar <kumarkr@us.ibm.com> wrote:
> When unregister_netdev() is called by the driver, it first calls
> unregister_netdevice() which
> drops it's last ref to the dev, making it zero. unregister_netdev() then
> calls rtnl_unlock() which
> calls netdev_run_todo(), which calls netdev_wait_allrefs() and only after
> that succeeds,
> does the driver do a free_netdev(). So the dev should not be freed while
> the wait_ref() is
> executing, and the original code looks correct.
That's correct.
> I don't know if it is some corruption on my system, some hardware problem ?
> I will look
> some more, also try to get a different machine.
It could be some 'user after free' or similar issue.
Just an idea of something else to look for.
My earlier comments about "putting to zero multiple times" were
misguided, I forgot that these days dev_put() just decrements the
count and does not do anything special when the count reaches zero.
next prev parent reply other threads:[~2003-11-06 19:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-06 19:58 [PATCH] panic during unregister_netdevice() Krishna Kumar
2003-11-06 19:59 ` David S. Miller [this message]
2003-11-06 21:07 ` Krishna Kumar
2003-11-06 21:14 ` David S. Miller
2003-11-07 19:01 ` [PATCH] Hang in downing interface with IPv6 PRIVACY Krishna Kumar
2003-11-09 6:30 ` David S. Miller
2004-01-10 1:40 ` [PATCH] Bugs in xfrm Krishna Kumar
2004-01-10 4:48 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2003-11-06 1:42 [PATCH] panic during unregister_netdevice() Krishna Kumar
2003-11-06 1:20 Krishna Kumar
2003-11-06 1:33 ` Stephen Hemminger
2003-11-06 1:16 Krishna Kumar
2003-11-06 0:42 Krishna Kumar
2003-11-06 1:09 ` Stephen Hemminger
2003-11-06 0:26 Krishna Kumar
2003-11-06 0:00 Krishna Kumar
2003-11-06 0:30 ` Stephen Hemminger
2003-11-06 0:33 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031106115935.0cd56745.davem@redhat.com \
--to=davem@redhat.com \
--cc=krkumar@us.ibm.com \
--cc=kumarkr@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).