From: "David S. Miller" <davem@redhat.com>
To: "Ihar 'Philips' Filipau" <filia@softhome.net>
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags
Date: Mon, 10 Nov 2003 23:12:38 -0800 [thread overview]
Message-ID: <20031110231238.4742a158.davem@redhat.com> (raw)
In-Reply-To: <3FAF7236.7020209@softhome.net>
On Mon, 10 Nov 2003 12:10:46 +0100
"Ihar 'Philips' Filipau" <filia@softhome.net> wrote:
> On line 1057 we have: "msg->msg_flags|=MSG_TRUNC;" to indicate that
> message was truncated.
>
> But on line 1073, where we make return status to user, we check
> against user suplied flags, but NOT msg->msg_flags.
>
> It looks like obvious typo.
Indeed, you're right.
Thanks for the report, I'll fix this in both 2.4.x and 2.6.x
prev parent reply other threads:[~2003-11-11 7:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-10 11:10 net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags Ihar 'Philips' Filipau
2003-11-11 7:12 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031110231238.4742a158.davem@redhat.com \
--to=davem@redhat.com \
--cc=filia@softhome.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).