* [2.6 PATCH] ipvs - avoid NULL ptr deref in __ip_vs_get_out_rt
@ 2003-11-11 23:46 Julian Anastasov
2003-11-11 23:48 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: Julian Anastasov @ 2003-11-11 23:46 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Wensong Zhang, morpheus
[-- Attachment #1: Type: TEXT/PLAIN, Size: 354 bytes --]
Hello,
The attached patch fixes the problem as reported from
Kris (morpheus at theendless.org) under subject "linux-2.6.0-test9 and
IPVS (Kernel OOPS) with sync daemon started.". Kris reported that
the fix works. It fixes a copy-and-paste bug which leads to dereferencing
a NULL ptr in __ip_vs_get_out_rt.
Regards
--
Julian Anastasov <ja@ssi.bg>
[-- Attachment #2: fix dest rt --]
[-- Type: TEXT/PLAIN, Size: 917 bytes --]
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1349 -> 1.1350
# net/ipv4/ipvs/ip_vs_xmit.c 1.6 -> 1.7
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/11/12 ja@ssi.bg 1.1350
# [IPVS]: avoid NULL ptr deref for dest in __ip_vs_get_out_rt
# --------------------------------------------
#
diff -Nru a/net/ipv4/ipvs/ip_vs_xmit.c b/net/ipv4/ipvs/ip_vs_xmit.c
--- a/net/ipv4/ipvs/ip_vs_xmit.c Wed Nov 12 01:00:35 2003
+++ b/net/ipv4/ipvs/ip_vs_xmit.c Wed Nov 12 01:00:35 2003
@@ -98,7 +98,7 @@
.oif = 0,
.nl_u = {
.ip4_u = {
- .daddr = dest->addr,
+ .daddr = cp->daddr,
.saddr = 0,
.tos = rtos, } },
};
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 PATCH] ipvs - avoid NULL ptr deref in __ip_vs_get_out_rt
2003-11-11 23:46 [2.6 PATCH] ipvs - avoid NULL ptr deref in __ip_vs_get_out_rt Julian Anastasov
@ 2003-11-11 23:48 ` David S. Miller
2003-11-12 0:01 ` Julian Anastasov
0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2003-11-11 23:48 UTC (permalink / raw)
To: Julian Anastasov; +Cc: netdev, wensong, morpheus
On Wed, 12 Nov 2003 01:46:43 +0200 (EET)
Julian Anastasov <ja@ssi.bg> wrote:
> The attached patch fixes the problem as reported from
> Kris (morpheus at theendless.org) under subject "linux-2.6.0-test9 and
> IPVS (Kernel OOPS) with sync daemon started.". Kris reported that
> the fix works. It fixes a copy-and-paste bug which leads to dereferencing
> a NULL ptr in __ip_vs_get_out_rt.
Applied, thanks Julian.
I assume 2.4.x does not need this fix.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 PATCH] ipvs - avoid NULL ptr deref in __ip_vs_get_out_rt
2003-11-11 23:48 ` David S. Miller
@ 2003-11-12 0:01 ` Julian Anastasov
0 siblings, 0 replies; 3+ messages in thread
From: Julian Anastasov @ 2003-11-12 0:01 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, wensong, morpheus
Hello,
On Tue, 11 Nov 2003, David S. Miller wrote:
> I assume 2.4.x does not need this fix.
Yes, 2.4 is ok
Regards
--
Julian Anastasov <ja@ssi.bg>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-11-12 0:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-11-11 23:46 [2.6 PATCH] ipvs - avoid NULL ptr deref in __ip_vs_get_out_rt Julian Anastasov
2003-11-11 23:48 ` David S. Miller
2003-11-12 0:01 ` Julian Anastasov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).