[2.6 PATCH] ipvs - avoid NULL ptr deref in __ip_vs_get_out_rt

[2.6 PATCH] ipvs - avoid NULL ptr deref in __ip_vs_get_out_rt

[Julian Anastasov]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 354 bytes --]


	Hello,

	The attached patch fixes the problem as reported from
Kris (morpheus at theendless.org) under subject "linux-2.6.0-test9 and 
IPVS (Kernel OOPS) with sync daemon started.". Kris reported that
the fix works. It fixes a copy-and-paste bug which leads to dereferencing 
a NULL ptr in __ip_vs_get_out_rt.

Regards

--
Julian Anastasov <ja@ssi.bg>

[-- Attachment #2: fix dest rt --]
[-- Type: TEXT/PLAIN, Size: 917 bytes --]

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1349  -> 1.1350 
#	net/ipv4/ipvs/ip_vs_xmit.c	1.6     -> 1.7    
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/11/12	ja@ssi.bg	1.1350
# [IPVS]: avoid NULL ptr deref for dest in __ip_vs_get_out_rt
# --------------------------------------------
#
diff -Nru a/net/ipv4/ipvs/ip_vs_xmit.c b/net/ipv4/ipvs/ip_vs_xmit.c
--- a/net/ipv4/ipvs/ip_vs_xmit.c	Wed Nov 12 01:00:35 2003
+++ b/net/ipv4/ipvs/ip_vs_xmit.c	Wed Nov 12 01:00:35 2003
@@ -98,7 +98,7 @@
 			.oif = 0,
 			.nl_u = {
 				.ip4_u = {
-					.daddr = dest->addr,
+					.daddr = cp->daddr,
 					.saddr = 0,
 					.tos = rtos, } },
 		};

Re: [2.6 PATCH] ipvs - avoid NULL ptr deref in __ip_vs_get_out_rt

[David S. Miller]

On Wed, 12 Nov 2003 01:46:43 +0200 (EET)
Julian Anastasov <ja@ssi.bg> wrote:

> 	The attached patch fixes the problem as reported from
> Kris (morpheus at theendless.org) under subject "linux-2.6.0-test9 and 
> IPVS (Kernel OOPS) with sync daemon started.". Kris reported that
> the fix works. It fixes a copy-and-paste bug which leads to dereferencing 
> a NULL ptr in __ip_vs_get_out_rt.

Applied, thanks Julian.

I assume 2.4.x does not need this fix.

Re: [2.6 PATCH] ipvs - avoid NULL ptr deref in __ip_vs_get_out_rt

[Julian Anastasov]

	Hello,

On Tue, 11 Nov 2003, David S. Miller wrote:

> I assume 2.4.x does not need this fix.

	Yes, 2.4 is ok

Regards

--
Julian Anastasov <ja@ssi.bg>