From: Stephen Hemminger <shemminger@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH] de4x5 - missing free on error path
Date: Wed, 12 Nov 2003 16:30:09 -0800 [thread overview]
Message-ID: <20031112163009.2be5e47d.shemminger@osdl.org> (raw)
NE54-de4x5 - fix missing free on error path - found by viro
diff -Nru a/drivers/net/tulip/de4x5.c b/drivers/net/tulip/de4x5.c
--- a/drivers/net/tulip/de4x5.c Tue Nov 11 14:15:07 2003
+++ b/drivers/net/tulip/de4x5.c Tue Nov 11 14:15:07 2003
@@ -1237,6 +1237,8 @@
if (lp->useSROM) {
lp->state = INITIALISED;
if (srom_infoleaf_info(dev)) {
+ dma_free_coherent (gendev, lp->dma_size,
+ lp->rx_ring, lp->dma_rings);
return -ENXIO;
}
srom_init(dev);
next reply other threads:[~2003-11-13 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-13 0:30 Stephen Hemminger [this message]
2003-11-13 1:40 ` [PATCH] de4x5 - missing free on error path Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031112163009.2be5e47d.shemminger@osdl.org \
--to=shemminger@osdl.org \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).