From: "David S. Miller" <davem@redhat.com>
To: Krishna Kumar <krkumar@us.ibm.com>
Cc: krkumar@us.ibm.com, netdev@oss.sgi.com, dlstevens@us.ibm.com
Subject: Re: [PATCH] ref count bug in MLDv2
Date: Wed, 12 Nov 2003 17:58:26 -0800 [thread overview]
Message-ID: <20031112175826.13850359.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0311121630100.1794-100000@linux.local>
On Wed, 12 Nov 2003 16:56:20 -0800 (PST)
Krishna Kumar <krkumar@us.ibm.com> wrote:
> Dave Stevens and I found this problem when the device is going down,
> mc_destroy_dev() calls igmp6_group_dropped which checks for IFF_UP before
> calling mld_add_delrec and posting a timer.
>
> IFF_UP need not be set though the device is going down (eg last address
> deletion). So timer can get started at this time. The problem is that
> when the timer fires (after ifdown is over) for the last time
> (mld_ifc_timer_expire), it does a __in6_dev_put() and that will not free
> up the idev.
>
> To fix that that the check must be for idev->dead instead.
Applied, thanks a lot Krishna.
prev parent reply other threads:[~2003-11-13 1:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OF9FB7F6ED.3B4FEB1E-ON88256DDD.0002886E@us.ibm.com>
2003-11-13 0:56 ` [PATCH] ref count bug in MLDv2 Krishna Kumar
2003-11-13 1:58 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031112175826.13850359.davem@redhat.com \
--to=davem@redhat.com \
--cc=dlstevens@us.ibm.com \
--cc=krkumar@us.ibm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).