From: Rask Ingemann Lambertsen <rask@sygehus.dk>
To: francois donzet <fdonzet@yahoo.fr>
Cc: netdev@oss.sgi.com
Subject: hw checksum acceleration (Was: problem in driver network code)
Date: Thu, 13 Nov 2003 22:48:31 +0100 [thread overview]
Message-ID: <20031113224831.A1052@sygehus.dk> (raw)
In-Reply-To: <20031110081417.55732.qmail@web25201.mail.ukl.yahoo.com>; from fdonzet@yahoo.fr on Mon, Nov 10, 2003 at 09:14:17AM +0100
On Mon, Nov 10, 2003 at 09:14:17AM +0100, francois donzet wrote:
> > What do you do with an IEEE 802.1q (VLAN) or 802.2
> > (LLC) packet? The VLAN
> > code in vlan_skb_recv() does not adjust skb->csum or
> > skb->ip_summed. Neither
> > does the 802.2 code.
>
> no matter the link layer header is 802.3,802.2 or
> 8021.q . Tcp checksum offloading is supported,
> whatever the type of the link layer (as skb->csum is
> computed without the link layer header).
The documentation says that skb->csum covers the whole packet as seen by
netif_rx(). eth_type_trans() pulls off the 14 byte header before netif_rx()
is called. But if the frame is really 802.1q or 802.2, then the extra bytes
of the header will be pulled off but skb->csum will still cover those bytes.
Unless, of course, the device knows about 802.1q and 802.2, but that wasn't
supposed to be necessary, was it?
--
Regards,
Rask Ingemann Lambertsen
prev parent reply other threads:[~2003-11-13 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-07 8:38 problem in driver network code francois donzet
2003-11-07 17:15 ` Rask Ingemann Lambertsen
2003-11-10 8:14 ` francois donzet
2003-11-13 21:48 ` Rask Ingemann Lambertsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031113224831.A1052@sygehus.dk \
--to=rask@sygehus.dk \
--cc=fdonzet@yahoo.fr \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).