[PATCH] UDP/IPv6 multicasting

[PATCH] UDP/IPv6 multicasting

[David Stevens]

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]





Dave,
      Below is a patch to fix a problem reported by Brian Buesker. When
binding to
two different multicast addresses on the same UDP port, a copy sent to
either multicast
address is delivered to both.

                        +-DLS

--- linux-2.6.0-test9-bk12/net/ipv6/udp.c 2003-11-07 14:13:21.000000000 -0800
+++ linux-2.6.0-test9-bk12F1/net/ipv6/udp.c     2003-11-14 14:51:05.000000000 -0800
@@ -551,6 +551,7 @@
                  if (!ipv6_addr_any(&np->rcv_saddr)) {
                        if (!ipv6_addr_cmp(&np->rcv_saddr, loc_addr))
                              return s;
+                       continue;
                  }
                  if(!inet6_mc_check(s, loc_addr, rmt_addr))
                        continue;

(See attached file: mcfix.patch.txt)

[-- Attachment #2: mcfix.patch.txt --]
[-- Type: application/octet-stream, Size: 370 bytes --]

--- linux-2.6.0-test9-bk12/net/ipv6/udp.c	2003-11-07 14:13:21.000000000 -0800
+++ linux-2.6.0-test9-bk12F1/net/ipv6/udp.c	2003-11-14 14:51:05.000000000 -0800
@@ -551,6 +551,7 @@
 			if (!ipv6_addr_any(&np->rcv_saddr)) {
 				if (!ipv6_addr_cmp(&np->rcv_saddr, loc_addr))
 					return s;
+				continue;
 			}
 			if(!inet6_mc_check(s, loc_addr, rmt_addr))
 				continue;

Re: [PATCH] UDP/IPv6 multicasting

[David S. Miller]

On Fri, 14 Nov 2003 16:11:50 -0700
David Stevens <dlstevens@us.ibm.com> wrote:

>       Below is a patch to fix a problem reported by Brian Buesker. When
> binding to
> two different multicast addresses on the same UDP port, a copy sent to
> either multicast
> address is delivered to both.

Thanks a lot David, I will review and probably apply this later
on today.

2.4.x has identical code in this spot so I'll put the fix there
as well and queue it up for 2.4.24-pre1.

Thanks again.