From: "David S. Miller" <davem@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@oss.sgi.com
Subject: Re: [IPV4] Always set hoplimit
Date: Tue, 18 Nov 2003 16:59:09 -0800 [thread overview]
Message-ID: <20031118165909.788d5388.davem@redhat.com> (raw)
In-Reply-To: <20031113110438.GA29522@gondor.apana.org.au>
On Thu, 13 Nov 2003 22:04:38 +1100
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Is there any reason why local/broadcast packets should have a ttl of zero?
> This is the result of the HOPLIMIT change as those packets doesn't get
> their HOPLIMIT set. This patch sets it for them.
>
> Am I missing something?
I don't believe I changed this behavior intentionally. Let me
look into the revision history to verify that. I'm likely going
to apply your fix tonight, thanks.
Although it is an interesting question because both broadcasts and
locally destined packets have no reason to make it past the local
subnet and thus have their TTL/HOPLIMIT decremented or tested. I
therefore cannot imagine a case where the current behavior would cause
a problem.
Did you run into an actual problem that led you to this issue? If
so, what was it? Or was this just determined by pure code review?
next prev parent reply other threads:[~2003-11-19 0:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-13 11:04 [IPV4] Always set hoplimit Herbert Xu
2003-11-19 0:59 ` David S. Miller [this message]
2003-11-19 1:08 ` Herbert Xu
2003-11-19 1:05 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031118165909.788d5388.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).