From: "David S. Miller" <davem@redhat.com>
To: David Stevens <dlstevens@us.ibm.com>
Cc: netdev@oss.sgi.com
Subject: Re: MLDv1 /proc/net/igmp6 timer printing [PATCH]
Date: Tue, 18 Nov 2003 22:57:18 -0800 [thread overview]
Message-ID: <20031118225718.25686a30.davem@redhat.com> (raw)
In-Reply-To: <OF8D427868.33352D02-ON88256DE3.001A7B55@us.ibm.com>
On Tue, 18 Nov 2003 21:55:40 -0700
David Stevens <dlstevens@us.ibm.com> wrote:
> The problem is the IPv6 multicast address flag
> "MAF_TIMER_RUNNING" is set on a join_group, and cleared
> by a report, but is never set again (e.g., from a query). The timer
> is set and running, but the /proc entry won't show it because it
> only reports the time left on the timer if the flag is set.
> Fix is to set the flag when the timer is set.
I want to apply this, but I'd like to ask you to fix a related
issue at the same time. The jiffies reported to userspace by
this multicast code does not convert HZ to USER_HZ, just include
linux/times.h and use jiffies_to_clock_t().
We recently had to fix similar issues in other networking procfs
files.
Thanks David.
next prev parent reply other threads:[~2003-11-19 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-19 4:55 MLDv1 /proc/net/igmp6 timer printing [PATCH] David Stevens
2003-11-19 6:57 ` David S. Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-11-19 7:59 David Stevens
2003-11-19 8:05 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031118225718.25686a30.davem@redhat.com \
--to=davem@redhat.com \
--cc=dlstevens@us.ibm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).