From: Jeff Garzik <jgarzik@pobox.com>
To: torvalds@osdl.org
Cc: netdev@oss.sgi.com
Subject: [BK PATCH] fix oopsable net driver bug
Date: Sun, 23 Nov 2003 12:36:11 -0500 [thread overview]
Message-ID: <20031123173611.GA27637@gtf.org> (raw)
dev_kfree_skb, unlike kfree, will oops if passed NULL...
and it might be passed NULL in this case, if skb_padto() returns NULL.
Linus, please do a
bk pull bk://gkernel.bkbits.net/net-drivers-2.5
This will update the following files:
drivers/net/sis190.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
through these ChangeSets:
<jgarzik@redhat.com> (03/11/20 1.1478)
[netdrvr sis190] fix oopsable bug in TX path, related to skb_padto return
Caught by Francois Romieu.
diff -Nru a/drivers/net/sis190.c b/drivers/net/sis190.c
--- a/drivers/net/sis190.c Sun Nov 23 12:34:07 2003
+++ b/drivers/net/sis190.c Sun Nov 23 12:34:07 2003
@@ -949,7 +949,8 @@
drop_tx:
tp->stats.tx_dropped++;
- dev_kfree_skb(skb);
+ if (skb)
+ dev_kfree_skb(skb);
return 0;
}
reply other threads:[~2003-11-23 17:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031123173611.GA27637@gtf.org \
--to=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).