netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH] hp100 -- fixes for new probing.
Date: Mon, 24 Nov 2003 15:44:59 -0800	[thread overview]
Message-ID: <20031124154459.6fe02a94.shemminger@osdl.org> (raw)

Fixes to net-drivers-2.5-exp patches for hp100
	* EISA device id table needs a terminating string.
	* if one driver built for all variations (ISA, EISA, PCI)
	  then try to have sane error handling on probe.

diff -Nru a/drivers/net/hp100.c b/drivers/net/hp100.c
--- a/drivers/net/hp100.c	Mon Nov 24 15:34:53 2003
+++ b/drivers/net/hp100.c	Mon Nov 24 15:34:53 2003
@@ -201,6 +201,7 @@
 	{ "HWP1990" }, /* HP J2577 */
 	{ "CPX0301" }, /* ReadyLink ENET100-VG4 */
 	{ "CPX0401" }, /* FreedomLine 100/VG */
+	{ "" }
 };
 MODULE_DEVICE_TABLE(eisa, hp100_eisa_tbl);
 #endif
@@ -3045,10 +3046,16 @@
 	err = hp100_isa_init();
 
 #ifdef CONFIG_EISA
-	err |= eisa_driver_register(&hp100_eisa_driver);
+	if (err && err != -ENODEV) 
+		return err;
+
+	err = eisa_driver_register(&hp100_eisa_driver);
 #endif
 #ifdef CONFIG_PCI
-	err |= pci_module_init(&hp100_pci_driver);
+	if (err && err != -ENODEV)
+		return err;
+
+	err = pci_module_init(&hp100_pci_driver);
 #endif
 	return err;
 }

             reply	other threads:[~2003-11-24 23:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-24 23:44 Stephen Hemminger [this message]
2003-12-07 18:48 ` [PATCH] hp100 -- fixes for new probing Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2004-02-23  8:48 Cacophonix
2004-02-23 17:49 ` Stephen Hemminger
2004-02-24 23:36   ` Cacophonix
2004-02-25  1:07     ` Stephen Hemminger
2004-02-25 21:33       ` Cacophonix
2004-02-25 21:40         ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031124154459.6fe02a94.shemminger@osdl.org \
    --to=shemminger@osdl.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).