From: Rask Ingemann Lambertsen <rask@sygehus.dk>
To: Ben Greear <greearb@candelatech.com>
Cc: "'netdev@oss.sgi.com'" <netdev@oss.sgi.com>
Subject: Re: [PATCH 3/3] rx_all e100 patch
Date: Wed, 26 Nov 2003 00:41:52 +0100 [thread overview]
Message-ID: <20031126004149.A1264@sygehus.dk> (raw)
In-Reply-To: <3FC39969.4030609@candelatech.com>; from greearb@candelatech.com on Tue, Nov 25, 2003 at 10:03:21AM -0800
On Tue, Nov 25, 2003 at 10:03:21AM -0800, Ben Greear wrote:
> Rask Ingemann Lambertsen wrote:
> >
> > I don't understand this part of the code. The 55x docs say that the IP
> > checksum bytes are transferred to memory _following_ the FCS.
>
> I can't find this in the docs, but it could easily be true. If you have a page/section
> number, please let me know.
Section 6.4.3.4.1, page 102 if you go by the document page numbers or page
110 if you go by xpdf's page numbers.
> I don't appear to have hardware that takes this
> branch at any rate. Anyone know which chipset/NIC has this particular rev-id?
The i82559. I wouldn't mind a few comment lines that map Intel's internal
names like D101M, D102 etc. into externally visible part numbers.
> Also, this should invalidate all of the hacks from the e100_D101M_checksum code...
I guess it does if you skb_put() the FCS along with the payload. I haven't
checked that, but I think you're right.
--
Regards,
Rask Ingemann Lambertsen
next prev parent reply other threads:[~2003-11-25 23:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-25 7:55 [PATCH 3/3] rx_all e100 patch Ben Greear
2003-11-25 15:21 ` Rask Ingemann Lambertsen
2003-11-25 18:03 ` Ben Greear
2003-11-25 23:41 ` Rask Ingemann Lambertsen [this message]
2003-11-25 16:56 ` Rask Ingemann Lambertsen
-- strict thread matches above, loose matches on Subject: below --
2003-11-25 17:39 Feldman, Scott
2003-11-25 18:05 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031126004149.A1264@sygehus.dk \
--to=rask@sygehus.dk \
--cc=greearb@candelatech.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).