From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>,
"YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B" <yoshfuji@linux-ipv6.org>,
davem@redhat.com,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
netdev@oss.sgi.com
Subject: Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy
Date: Thu, 27 Nov 2003 22:33:48 +0000 [thread overview]
Message-ID: <20031127223348.G25015@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20031127221928.F25015@flint.arm.linux.org.uk>; from rmk+lkml@arm.linux.org.uk on Thu, Nov 27, 2003 at 10:19:28PM +0000
On Thu, Nov 27, 2003 at 10:19:28PM +0000, Russell King wrote:
> Note: we should really fix the generic strncpy() - there are places in
> the kernel source which rely on the x86 strncpy() behaviour today (eg,
> binfmt_*.c core file generation.)
Sorry, bad example. Hmm, from a glance around, it seems that all of
the places which use strncpy() implicitly zero the buffer prior to
using strncpy().
This means that the x86 strncpy is doing unnecessary zeroing. I do
remember Alan complaining about the last set of strlcpy() stuff
introducing information leaks - maybe those got fixed though.
Ok, I don't know where the kernel stands on this issue anymore.
Can someone definitively provide a statement of exactly what the
kernel expects of strncpy() ?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2003-11-27 22:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1069920883.2476.1.camel@teapot.felipe-alfaro.com>
2003-11-27 8:33 ` [PATCH 2.6]: IPv6: strcpy -> strlcpy YOSHIFUJI Hideaki / 吉藤英明
2003-11-27 10:59 ` David S. Miller
2003-11-27 12:04 ` Felipe Alfaro Solana
2003-11-27 12:09 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-27 19:46 ` Russell King
2003-11-27 19:54 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-27 20:00 ` Russell King
2003-11-27 20:47 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-27 22:06 ` Felipe Alfaro Solana
2003-11-27 22:19 ` Russell King
2003-11-27 22:33 ` Russell King [this message]
2003-11-28 1:34 ` Mitchell Blank Jr
2003-11-27 23:03 ` Felipe Alfaro Solana
2003-11-28 0:23 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-28 0:26 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-28 0:40 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-28 9:54 ` Felipe Alfaro Solana
2003-11-28 11:22 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031127223348.G25015@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=davem@redhat.com \
--cc=felipe_alfaro@linuxmail.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).