netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@oss.sgi.com
Subject: Re: [ROUTE] PMTU only works on half the time
Date: Mon, 1 Dec 2003 13:51:54 -0800	[thread overview]
Message-ID: <20031201135154.6906454c.davem@redhat.com> (raw)
In-Reply-To: <20031201204700.GA20349@gondor.apana.org.au>

On Tue, 2 Dec 2003 07:47:00 +1100
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> On Tue, Dec 02, 2003 at 07:16:51AM +1100, herbert wrote:
> > 
> > I found out that PMTU only works on those routing cache entries where
> > rt_src != 0.  This patch should make it work for all matching entries.
> 
> That patch removed one line too many.  This one should be better.

Hmmm... 

Herbert, do you see how the outer loop and the skey[] thing works in
this PMTU handling code?  This takes care of comparing both iph->saddr
and '0' against rt->rt_src.

  reply	other threads:[~2003-12-01 21:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-01 20:16 [ROUTE] PMTU only works on half the time Herbert Xu
2003-12-01 20:47 ` Herbert Xu
2003-12-01 21:51   ` David S. Miller [this message]
2003-12-01 22:05     ` Herbert Xu
2003-12-01 22:21       ` David S. Miller
2003-12-01 23:22         ` David S. Miller
2003-12-02 10:10           ` Herbert Xu
2003-12-02 10:27             ` David S. Miller
2003-12-02 10:33               ` Herbert Xu
2003-12-01 23:30   ` Julian Anastasov
2003-12-01 23:50     ` David S. Miller
2003-12-02  0:04       ` Julian Anastasov
2003-12-02  0:07       ` Julian Anastasov
2003-12-02  0:08         ` David S. Miller
2003-12-02  1:53       ` Julian Anastasov
2003-12-02 23:40       ` Julian Anastasov
2003-12-03  0:07         ` David S. Miller
2003-12-03  0:39         ` David S. Miller
2003-12-03  1:43           ` Julian Anastasov
2003-12-03 22:03           ` Julian Anastasov
2003-12-05 20:43             ` David S. Miller
2003-12-06  7:52               ` Julian Anastasov
2003-12-10 23:15                 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031201135154.6906454c.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).