* [patch] 2.4 lacks dummy SET_NETDEV_DEV
@ 2003-11-10 18:19 Pekka Pietikainen
2003-11-10 22:14 ` Pekka Pietikainen
0 siblings, 1 reply; 5+ messages in thread
From: Pekka Pietikainen @ 2003-11-10 18:19 UTC (permalink / raw)
To: netdev
Just noticed that 2.4 doesn't have a dummy SET_NETDEV_DEV for drivers
written for 2.6 (like the b44 fixes that got merged a few days back, so
it wouldn't actually compile :-) )
--- linux-2.4.22/include/linux/netdevice.h.orig 2003-10-03 20:30:14.000000000 +0300
+++ linux-2.4.22/include/linux/netdevice.h 2003-11-10 20:12:46.480609408 +0200
@@ -454,6 +454,8 @@
#endif /* CONFIG_NET_DIVERT */
};
+/* 2.6 compatibility */
+#define SET_NETDEV_DEV(net, pdev) do { } while (0)
struct packet_type
{
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch] 2.4 lacks dummy SET_NETDEV_DEV
2003-11-10 18:19 [patch] 2.4 lacks dummy SET_NETDEV_DEV Pekka Pietikainen
@ 2003-11-10 22:14 ` Pekka Pietikainen
2003-11-11 6:14 ` David S. Miller
0 siblings, 1 reply; 5+ messages in thread
From: Pekka Pietikainen @ 2003-11-10 22:14 UTC (permalink / raw)
To: netdev
On Mon, Nov 10, 2003 at 08:19:17PM +0200, Pekka Pietikainen wrote:
> Just noticed that 2.4 doesn't have a dummy SET_NETDEV_DEV for drivers
> written for 2.6 (like the b44 fixes that got merged a few days back, so
> it wouldn't actually compile :-) )
Ah, except Jeff merged a version without the call so there should be no
problem :-) (I still like the idea of being able to use exactly the same driver
source on 2.4/2.6 though)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] 2.4 lacks dummy SET_NETDEV_DEV
2003-11-10 22:14 ` Pekka Pietikainen
@ 2003-11-11 6:14 ` David S. Miller
2003-12-02 10:40 ` Pekka Pietikainen
0 siblings, 1 reply; 5+ messages in thread
From: David S. Miller @ 2003-11-11 6:14 UTC (permalink / raw)
To: Pekka Pietikainen; +Cc: netdev
On Tue, 11 Nov 2003 00:14:30 +0200
Pekka Pietikainen <pp@ee.oulu.fi> wrote:
> (I still like the idea of being able to use exactly the same driver
> source on 2.4/2.6 though)
I agree, someone should merge in the dummy SET_NETDEV_DEV once
Marcelo starts up 2.4.24-preX
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] 2.4 lacks dummy SET_NETDEV_DEV
2003-11-11 6:14 ` David S. Miller
@ 2003-12-02 10:40 ` Pekka Pietikainen
2003-12-02 11:28 ` David S. Miller
0 siblings, 1 reply; 5+ messages in thread
From: Pekka Pietikainen @ 2003-12-02 10:40 UTC (permalink / raw)
To: netdev; +Cc: marcelo.tosatti
On Mon, Nov 10, 2003 at 10:14:29PM -0800, David S. Miller wrote:
> On Tue, 11 Nov 2003 00:14:30 +0200
> Pekka Pietikainen <pp@ee.oulu.fi> wrote:
>
> > (I still like the idea of being able to use exactly the same driver
> > source on 2.4/2.6 though)
>
> I agree, someone should merge in the dummy SET_NETDEV_DEV once
> Marcelo starts up 2.4.24-preX
Ping :-)
--- linux-2.4.22-1.2115.nptl/include/linux/netdevice.h.orig 2003-11-10 20:08:42.922635848 +0200
+++ linux-2.4.22-1.2115.nptl/include/linux/netdevice.h 2003-11-10 20:09:09.754556776 +0200
@@ -456,6 +456,8 @@
#endif /* CONFIG_NET_DIVERT */
};
+/* 2.6 compatibility */
+#define SET_NETDEV_DEV(net, pdev) do { } while (0)
struct packet_type
{
--
Pekka Pietikainen
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch] 2.4 lacks dummy SET_NETDEV_DEV
2003-12-02 10:40 ` Pekka Pietikainen
@ 2003-12-02 11:28 ` David S. Miller
0 siblings, 0 replies; 5+ messages in thread
From: David S. Miller @ 2003-12-02 11:28 UTC (permalink / raw)
To: Pekka Pietikainen; +Cc: netdev, marcelo.tosatti
On Tue, 2 Dec 2003 12:40:25 +0200
Pekka Pietikainen <pp@ee.oulu.fi> wrote:
> On Mon, Nov 10, 2003 at 10:14:29PM -0800, David S. Miller wrote:
> > I agree, someone should merge in the dummy SET_NETDEV_DEV once
> > Marcelo starts up 2.4.24-preX
>
> Ping :-)
Yes Marcelo, please apply this.
> --- linux-2.4.22-1.2115.nptl/include/linux/netdevice.h.orig 2003-11-10 20:08:42.922635848 +0200
> +++ linux-2.4.22-1.2115.nptl/include/linux/netdevice.h 2003-11-10 20:09:09.754556776 +0200
> @@ -456,6 +456,8 @@
> #endif /* CONFIG_NET_DIVERT */
> };
>
> +/* 2.6 compatibility */
> +#define SET_NETDEV_DEV(net, pdev) do { } while (0)
>
> struct packet_type
> {
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-12-02 11:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-11-10 18:19 [patch] 2.4 lacks dummy SET_NETDEV_DEV Pekka Pietikainen
2003-11-10 22:14 ` Pekka Pietikainen
2003-11-11 6:14 ` David S. Miller
2003-12-02 10:40 ` Pekka Pietikainen
2003-12-02 11:28 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).