From: "David S. Miller" <davem@redhat.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: herbert@gondor.apana.org.au, netdev@oss.sgi.com
Subject: Re: [ROUTE] PMTU only works on half the time
Date: Tue, 2 Dec 2003 16:39:02 -0800 [thread overview]
Message-ID: <20031202163902.2deb43a7.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0312030121130.1237-100000@u.domain.uli>
On Wed, 3 Dec 2003 01:40:06 +0200 (EET)
Julian Anastasov <ja@ssi.bg> wrote:
> - ip_rt_frag_needed now provides interface index
I disagree with this.
There is no connection between the route (and thus output
device) we used to send a packet and the interface on which
an ICMP for that packet comes back upon. Think assymetric
routes.
You changes mean that for routes with specific output interfaces,
we will ignore ICMPs for those routes that arrive on other interfaces
due to assymetric routing.
Why don't you create a seperate patch that just has the TOS masking
changes? That's much less controversial and thus something I'm likely
to apply.
next prev parent reply other threads:[~2003-12-03 0:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-01 20:16 [ROUTE] PMTU only works on half the time Herbert Xu
2003-12-01 20:47 ` Herbert Xu
2003-12-01 21:51 ` David S. Miller
2003-12-01 22:05 ` Herbert Xu
2003-12-01 22:21 ` David S. Miller
2003-12-01 23:22 ` David S. Miller
2003-12-02 10:10 ` Herbert Xu
2003-12-02 10:27 ` David S. Miller
2003-12-02 10:33 ` Herbert Xu
2003-12-01 23:30 ` Julian Anastasov
2003-12-01 23:50 ` David S. Miller
2003-12-02 0:04 ` Julian Anastasov
2003-12-02 0:07 ` Julian Anastasov
2003-12-02 0:08 ` David S. Miller
2003-12-02 1:53 ` Julian Anastasov
2003-12-02 23:40 ` Julian Anastasov
2003-12-03 0:07 ` David S. Miller
2003-12-03 0:39 ` David S. Miller [this message]
2003-12-03 1:43 ` Julian Anastasov
2003-12-03 22:03 ` Julian Anastasov
2003-12-05 20:43 ` David S. Miller
2003-12-06 7:52 ` Julian Anastasov
2003-12-10 23:15 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031202163902.2deb43a7.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=ja@ssi.bg \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).