netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Nivedita Singhvi <niv@us.ibm.com>
Cc: ja@ssi.bg, ak@suse.de, ruddk@us.ibm.com, kuznet@ms2.inr.ac.ru,
	netdev@oss.sgi.com, chester.f.johnson@intel.com
Subject: Re: PMTU issues due to TOS field manipulation (for DSCP)
Date: Wed, 10 Dec 2003 14:51:49 -0800	[thread overview]
Message-ID: <20031210145149.2bd89e9b.davem@redhat.com> (raw)
In-Reply-To: <3FD79FF1.8000505@us.ibm.com>


Here is my take on this, as far as Linux is concerned.

I agree with the three behaviors proposed by Julian.
However I have some slight trouble with the ignore-TOS-for-
PMTU idea, implementation wise.

Walking the routing hash table for each possible TOS value
is going to be computationally expensive, and is inviting
computational complexity DDoS attacks by bombing the machine
with PMTU ICMP messages.

That is the most obvious implementation, and I'm not saying there
are not others.  I just have no alternatives in mind right now :)

But once that issue is resolved I'm more than happy to put a patch
in which does this stuff.

We even have been speaking about this in other threads on netdev
wrt. Julian's patches.  TOS is truly a value with only network local
meaning and hops are going to modify the value on us.  I'm actually
surprised this is the first time the issue has been seriously hit.

  reply	other threads:[~2003-12-10 22:51 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-10 18:23 PMTU issues due to TOS field manipulation (for DSCP) Kevin W. Rudd
2003-12-10 19:34 ` Andi Kleen
2003-12-10 20:20   ` Julian Anastasov
2003-12-10 20:33     ` Nivedita Singhvi
2003-12-10 21:18       ` Julian Anastasov
2003-12-10 22:36         ` Nivedita Singhvi
2003-12-10 22:51           ` David S. Miller [this message]
2003-12-10 23:15             ` Julian Anastasov
2003-12-10 23:20               ` David S. Miller
2003-12-11  0:06                 ` Julian Anastasov
2003-12-11  0:09                   ` David S. Miller
2003-12-11  0:34                     ` Julian Anastasov
2003-12-12  8:31                       ` David S. Miller
2003-12-12 23:38                         ` Julian Anastasov
2003-12-18 23:17                           ` Kevin W. Rudd
2004-01-19 22:43                           ` Kevin W. Rudd
2004-01-20  4:29                             ` David S. Miller
2003-12-13  0:10                         ` Julian Anastasov
2004-03-04  9:36                           ` David S. Miller
2004-03-04 20:56                             ` Julian Anastasov
2004-03-04 22:02                               ` kuznet
2004-03-06 11:55                                 ` Julian Anastasov
2004-03-06 16:02                                 ` Julian Anastasov
2003-12-10 20:26   ` Kevin W. Rudd
2003-12-10 20:52     ` Andi Kleen
2003-12-10 20:30   ` Nivedita Singhvi
2003-12-10 20:55     ` Andi Kleen
2003-12-10 21:11       ` Nivedita Singhvi
  -- strict thread matches above, loose matches on Subject: below --
2003-12-10 21:35 Johnson, Chester F
2003-12-10 23:36 Johnson, Chester F
2003-12-11  0:17 ` Julian Anastasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031210145149.2bd89e9b.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=ak@suse.de \
    --cc=chester.f.johnson@intel.com \
    --cc=ja@ssi.bg \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@oss.sgi.com \
    --cc=niv@us.ibm.com \
    --cc=ruddk@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).