From: maximilian attems <janitor@sternwelten.at>
To: Chris Wright <chrisw@osdl.org>
Cc: netdev@oss.sgi.com
Subject: [PATCH 1/5] tun check error on memcpy_fromiovec
Date: Fri, 19 Dec 2003 11:34:58 +0100 [thread overview]
Message-ID: <20031219103457.GD1213@mail.sternwelten.at> (raw)
In-Reply-To: <20031208202302.C30587@build.pdx.osdl.net>
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
hey chris,
after applying your 4 patches on top of linux-2.6.0
+ experimental net,
found 2 last unchecked memcpy_fromiovec in tun.c
patch bellow fixes the second call,
the first is beyond me, please complete this patch :)
compile tested
thx max
--- linux-2.6.0-net/drivers/net/tun.c 2003-12-19 11:27:38.000000000 +0100
+++ linux/drivers/net/tun.c 2003-12-19 11:19:33.000000000 +0100
@@ -193,7 +193,10 @@
}
skb_reserve(skb, 2);
- memcpy_fromiovec(skb_put(skb, len), iv, len);
+ if (memcpy_fromiovec(skb_put(skb, len), iv, len)) {
+ kfree_skb(skb);
+ return -EFAULT;
+ }
skb->dev = tun->dev;
switch (tun->flags & TUN_TYPE_MASK) {
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-12-19 10:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 4:23 [PATCH 1/4] ax25 check error on memcpy_fromiovec Chris Wright
2003-12-09 4:24 ` [PATCH 2/4] irda " Chris Wright
2003-12-09 4:25 ` [PATCH 3/4] netrom " Chris Wright
2003-12-09 4:27 ` [PATCH 4/4] rose " Chris Wright
2003-12-09 5:39 ` [PATCH 1/4] ax25 " David S. Miller
2003-12-09 5:41 ` Chris Wright
2003-12-19 10:34 ` maximilian attems [this message]
2003-12-19 14:23 ` [PATCH 1/5] tun " Jeff Garzik
2004-01-17 0:45 ` Chris Wright
2004-01-21 20:49 ` Max Krasnyansky
2004-01-23 2:13 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031219103457.GD1213@mail.sternwelten.at \
--to=janitor@sternwelten.at \
--cc=chrisw@osdl.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).