From: Francois Romieu <romieu@fr.zoreil.com>
To: netdev@oss.sgi.com
Cc: Jeff Garzik <jgarzik@pobox.com>
Subject: [PATCH] Bogus return status in drivers/net/amd8111e.c
Date: Sat, 20 Dec 2003 01:17:18 +0100 [thread overview]
Message-ID: <20031220011718.A2442@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20031219233231.A2420@electric-eye.fr.zoreil.com>; from romieu@fr.zoreil.com on Fri, Dec 19, 2003 at 11:32:31PM +0100
Patch applies on top of 2.6.0 + Jeff Garzik's 2.6.0-test11-bk5-netdrvr-exp2
The status variable is not set before branching to the error path.
drivers/net/amd8111e.c | 2 ++
1 files changed, 2 insertions(+)
diff -puN drivers/net/amd8111e.c~trivial-amd8111e-fscked-return-status drivers/net/amd8111e.c
--- linux-2.6.0-vanilla/drivers/net/amd8111e.c~trivial-amd8111e-fscked-return-status 2003-12-19 23:34:46.000000000 +0100
+++ linux-2.6.0-vanilla-fr/drivers/net/amd8111e.c 2003-12-19 23:37:15.000000000 +0100
@@ -1819,6 +1819,8 @@ static int __devinit amd8111e_probe_one(
pci_set_master(pdev);
+ err = -EIO;
+
/* Find power-management capability. */
if((pm_cap = pci_find_capability(pdev, PCI_CAP_ID_PM))==0){
printk(KERN_ERR "amd8111e: No Power Management capability, "
_
next prev parent reply other threads:[~2003-12-20 0:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-19 22:32 [PATCH] Bogus return status in drivers/net/tg3.c Francois Romieu
2003-12-20 0:17 ` Francois Romieu [this message]
2003-12-20 0:43 ` [PATCH] 2.6.0 - r8169 64 bit Francois Romieu
2003-12-20 1:09 ` Francois Romieu
2003-12-20 5:44 ` [PATCH] Bogus return status in drivers/net/tg3.c David S. Miller
2003-12-20 5:49 ` Jeff Garzik
2003-12-20 5:54 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031220011718.A2442@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).