From: "David S. Miller" <davem@redhat.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: acme@conectiva.com.br, mpm@selenic.com, netdev@oss.sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH-2.6.0-tiny] "uninline" {lock,release}_sock
Date: Sun, 28 Dec 2003 01:23:29 -0800 [thread overview]
Message-ID: <20031228012329.43003de5.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0312280017060.2274@home.osdl.org>
On Sun, 28 Dec 2003 00:23:07 -0800 (PST)
Linus Torvalds <torvalds@osdl.org> wrote:
> Function calls aren't all that expensive, especially with FASTCALL() etc
> to show that you don't have to follow the common calling conventions.
> Right now I think FASTCALL() only matters on x86, but some other
> architectures could make it mean "smaller call clobbered list" or similar.
>
> Have you benchmarked with the smaller kernel?
To be honest I think {lock,release}_sock() should both be uninlined
always.
It almost made sense to inline these things before the might_sleep()
was added, now it definitely makes no sense.
next prev parent reply other threads:[~2003-12-28 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-28 7:54 [PATCH-2.6.0-tiny] "uninline" {lock,release}_sock Arnaldo Carvalho de Melo
2003-12-28 8:23 ` Linus Torvalds
2003-12-28 9:23 ` David S. Miller [this message]
2003-12-28 18:42 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031228012329.43003de5.davem@redhat.com \
--to=davem@redhat.com \
--cc=acme@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@oss.sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).