From: "David S. Miller" <davem@redhat.com>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: shemminger@osdl.org, netdev@oss.sgi.com
Subject: Re: [PATCH] Fix loopback over bridge port
Date: Mon, 29 Dec 2003 17:43:20 -0800 [thread overview]
Message-ID: <20031229174320.283fd28c.davem@redhat.com> (raw)
In-Reply-To: <200312271536.46940.bdschuym@pandora.be>
On Sat, 27 Dec 2003 15:36:46 +0100
Bart De Schuymer <bdschuym@pandora.be> wrote:
> The patch below fixes this by adding a check in __handle_bridge().
> It also changes br_netfilter.c by only doing the paranoid checks of
> br_nf_post_routing() when CONFIG_NETFILTER_DEBUG is set. I think the
> loopback fix will get rid of any skbuffs matching those paranoid checks.
>
> The patch also introduces/removes some whitespace in br_netfilter.c.
Both 2.4.x and 2.6.x variants applied, thanks Bart.
> I think the code (in net/ipv4/ip_output.c::ip_dev_loopback_xmit())
> __skb_pull(newskb, newskb->nh.raw - newskb->data);
> is useless, as data always points to the network header at that moment. But
> that's not really my territory...
I'll look into this, it might be needed for proper packet sniffer
handling but that's just an offhand guess...
next prev parent reply other threads:[~2003-12-30 1:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-27 14:36 [PATCH] Fix loopback over bridge port Bart De Schuymer
2003-12-30 1:43 ` David S. Miller [this message]
2004-01-01 20:38 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031229174320.283fd28c.davem@redhat.com \
--to=davem@redhat.com \
--cc=bdschuym@pandora.be \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).