From: Amir Noam <amir.noam@intel.com>
To: "Jeff Garzik" <jgarzik@pobox.com>,
"Hen, Shmulik" <shmulik.hen@intel.com>
Cc: "Marom, Noam" <noam.marom@intel.com>, <netdev@oss.sgi.com>,
<fubar@us.ibm.com>
Subject: Re: major bonding bug?
Date: Tue, 30 Dec 2003 18:45:14 +0200 [thread overview]
Message-ID: <200312301845.14275.amir.noam@intel.com> (raw)
In-Reply-To: <E6F7D288B394A64585E67497E5126BA601F991CE@hasmsx403.iil.intel.com>
On Tuesday 30 December 2003 06:31 pm, Jeff Garzik wrote:
> hmmm...
>
>
> It looks like a lot of code now depends on global variable
> "bond_mode".
Actually, this has always been the case in the bonding module.
> This looks very wrong... bonding mode should be per-interface, not
> global to the entire driver. What happens when a user wants
> BOND_MODE_ROUNDROBIN on bond0, and BOND_MODE_TLB on bond1?
We agree that it looks very wrong, and this is in fact one of the
features we've been working on lately. It is not a trivial fix,
since, as you've noted, a lot of the code depends on the bond
settings being global. We plan to start releasing patches to address
this issue very soon (probably even starting tomorrow).
--
Amir
next parent reply other threads:[~2003-12-30 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E6F7D288B394A64585E67497E5126BA601F991CE@hasmsx403.iil.intel.com>
2003-12-30 16:45 ` Amir Noam [this message]
2003-12-31 0:03 ` major bonding bug? Jay Vosburgh
[not found] <E791C176A6139242A988ABA8B3D9B38A014C965E@hasmsx403.iil.intel.com>
2003-12-30 16:31 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200312301845.14275.amir.noam@intel.com \
--to=amir.noam@intel.com \
--cc=fubar@us.ibm.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=noam.marom@intel.com \
--cc=shmulik.hen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).