From: Amir Noam <amir.noam@intel.com>
To: "Jeff Garzik" <jgarzik@pobox.com>
Cc: bonding-devel@lists.sourceforge.net, netdev@oss.sgi.com
Subject: [PATCH] [bonding 2.4] Fix compilation warning in bond_alb.c
Date: Wed, 31 Dec 2003 11:21:46 +0200 [thread overview]
Message-ID: <200312311121.48888.amir.noam@intel.com> (raw)
The IPX_TYPE_* constants and ipxhdr.ipx_type are u8 values, so we
shouldn't use __constant_htons().
diff -Nuarp a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
--- a/drivers/net/bonding/bond_alb.c Tue Dec 30 19:24:00 2003
+++ b/drivers/net/bonding/bond_alb.c Tue Dec 30 19:24:02 2003
@@ -1229,8 +1229,7 @@ int bond_alb_xmit(struct sk_buff *skb, s
break;
}
- if (skb->nh.ipxh->ipx_type !=
- __constant_htons(IPX_TYPE_NCP)) {
+ if (skb->nh.ipxh->ipx_type != IPX_TYPE_NCP) {
/* The only protocol worth balancing in
* this family since it has an "ARP" like
* mechanism
next reply other threads:[~2003-12-31 9:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-31 9:21 Amir Noam [this message]
2003-12-31 12:35 ` [PATCH] [bonding 2.4] Fix compilation warning in bond_alb.c Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200312311121.48888.amir.noam@intel.com \
--to=amir.noam@intel.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).