From: Jay Vosburgh <fubar@us.ibm.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org, andy@greyhouse.net
Subject: Re: [PATCH 1/6] Convert bonding timers to workqueues
Date: Mon, 15 Oct 2007 12:08:59 -0700 [thread overview]
Message-ID: <20038.1192475339@death> (raw)
In-Reply-To: <4713B44E.7030902@pobox.com>
Jeff Garzik <jgarzik@pobox.com> wrote:
>Jay Vosburgh wrote:
>> Convert bonding timers to workqueues. This converts the various
>> monitor functions to run in periodic work queues instead of timers. This
>> patch introduces the framework and convers the calls, but does not resolve
>> various locking issues, and does not stand alone.
>>
>> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
>> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
>
>"does not stand alone" == it is not bisectable? That's a problem.
The patch will compile fine (this is true for any point in the
series), but it's possible for bonding to deadlock or misbehave when
doing certain operations. Those problems are addressed in the later
patches.
I didn't want to just vomit out one big mega-patch that has the
whole set of changes, because that's harder to understand, and the later
patches generally address discrete issues.
Does that make you more or less nervous about its bisectability?
I can repost the whole thing as a big blob if that's what you'd prefer.
>Anyway, we have more fun fish to fry: after applying the IPoIB bonding
>patchset, this no longer applies...
Yah, I'll rebase it (once I know your blob vs. not-blob
preference). I wasn't sure how long the IPoIB mystery bug hunt was
going to take.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2007-10-15 19:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 4:14 [PATCH 0/6] bonding workqueue and lock rework Jay Vosburgh
2007-10-11 4:14 ` [PATCH 1/6] Convert bonding timers to workqueues Jay Vosburgh
2007-10-11 4:14 ` [PATCH 2/6] Convert balance-rr transmit to new locking Jay Vosburgh
2007-10-11 4:14 ` [PATCH 3/6] Convert miimon " Jay Vosburgh
2007-10-11 4:14 ` [PATCH 4/6] Convert locks to _bh, rework alb locking for " Jay Vosburgh
2007-10-11 4:14 ` [PATCH 5/6] Convert more locks to _bh, acquire rtnl, " Jay Vosburgh
2007-10-11 4:14 ` [PATCH 6/6] Acquire correct locks in alb for promisc change Jay Vosburgh
2007-10-15 18:41 ` [PATCH 1/6] Convert bonding timers to workqueues Jeff Garzik
2007-10-15 19:08 ` Jay Vosburgh [this message]
2007-10-22 14:55 ` Mike Snitzer
2007-10-22 18:34 ` Jeff Garzik
2007-10-22 18:57 ` Jay Vosburgh
-- strict thread matches above, loose matches on Subject: below --
2007-10-18 0:37 [PATCH 0/6] bonding workqueue and lock rework Jay Vosburgh
2007-10-18 0:37 ` [PATCH 1/6] Convert bonding timers to workqueues Jay Vosburgh
2007-10-24 0:42 ` Jeff Garzik
2007-10-24 1:00 ` Jay Vosburgh
2007-10-24 1:13 ` Andy Gospodarek
2007-10-24 1:19 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20038.1192475339@death \
--to=fubar@us.ibm.com \
--cc=andy@greyhouse.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).