From: "David S. Miller" <davem@redhat.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: benh@kernel.crashing.org, linux-kernel@vger.kernel.org,
netdev@oss.sgi.com
Subject: Re: Problem with dev_kfree_skb_any() in 2.6.0
Date: Thu, 1 Jan 2004 12:42:18 -0800 [thread overview]
Message-ID: <20040101124218.258e8b73.davem@redhat.com> (raw)
In-Reply-To: <3FF1B939.1090108@pobox.com>
On Tue, 30 Dec 2003 12:43:21 -0500
Jeff Garzik <jgarzik@pobox.com> wrote:
> Luckily, I feel there is an easy solution, as shown in the attached
> patch. We _already_ queue skbs in dev_kfree_skb_irq(). Therefore,
> dev_kfree_skb_any() can simply use precisely that same solution. The
> raise-softirq code will immediately proceed to action if we are not in
> hard IRQ context, otherwise it will follow the expected path.
Ok, this is reasonable and works.
Though, is there any particular reason you don't like adding a
"|| irqs_disabled()" check to the if statement instead?
I prefer that solution better actually.
next prev parent reply other threads:[~2004-01-01 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1072567054.4112.14.camel@gaston>
[not found] ` <20031227170755.4990419b.davem@redhat.com>
[not found] ` <3FF0FA6A.8000904@pobox.com>
[not found] ` <20031229205157.4c631f28.davem@redhat.com>
[not found] ` <20031230051519.GA6916@gtf.org>
[not found] ` <20031229220122.30078657.davem@redhat.com>
[not found] ` <3FF11745.4060705@pobox.com>
[not found] ` <20031229221345.31c8c763.davem@redhat.com>
2003-12-30 17:43 ` Problem with dev_kfree_skb_any() in 2.6.0 Jeff Garzik
2004-01-01 20:42 ` David S. Miller [this message]
2004-01-02 2:58 ` Jeff Garzik
2004-01-06 3:54 ` David S. Miller
2004-03-29 15:46 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040101124218.258e8b73.davem@redhat.com \
--to=davem@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).