netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/4] [bonding 2.4] Add support for the bond_hook in bonding
@ 2004-01-08 16:24 Amir Noam
  0 siblings, 0 replies; only message in thread
From: Amir Noam @ 2004-01-08 16:24 UTC (permalink / raw)
  To: Jeff Garzik, Jay Vosburgh; +Cc: bonding-devel, netdev

Add support for the bond_hook in bonding, and use it to export some
parameters to the calling app. These parameters will be needed later
by the application for dynamic configuration of bonding interfaces.


diff -Nuarp a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
--- a/drivers/net/bonding/bond_main.c	Thu Jan  8 18:03:23 2004
+++ b/drivers/net/bonding/bond_main.c	Thu Jan  8 18:03:25 2004
@@ -599,6 +599,7 @@ static struct bond_parm_tbl bond_mode_tb
 
 /*-------------------------- Forward declarations ---------------------------*/
 
+extern void bond_ioctl_set(int (*hook)(unsigned long));
 static inline void bond_set_mode_ops(struct net_device *bond_dev, int mode);
 
 /*---------------------------- General routines -----------------------------*/
@@ -3899,6 +3900,57 @@ static void bond_free_all(void)
 #endif
 }
 
+static int bond_ioctl_deviceless(unsigned long arg)
+{
+	void *addr = (void *)arg;
+	u32 cmd;
+
+	if (!capable(CAP_NET_ADMIN)) {
+		return -EPERM;
+	}
+
+	if (get_user(cmd, (u32 *)addr)) {
+		return -EFAULT;
+	}
+
+	switch (cmd) {
+	case BOND_CMD_DRV_INFO: {
+		struct bond_ioctl_drv_info drvinfo;
+
+		if (copy_from_user(&drvinfo, addr, sizeof(drvinfo))) {
+			return -EFAULT;
+		}
+
+		/* This is for backward compatibility only.
+		 * Unconditionaly set both global abi_ver vars so we can block
+		 * old ioctls in bond_do_ioctl().
+		 */
+		orig_app_abi_ver = drvinfo.abi_ver;
+		app_abi_ver = drvinfo.abi_ver;
+
+		drvinfo.abi_ver = BOND_ABI_VERSION;
+		drvinfo.num_prms = 0;
+		drvinfo.num_arp_targets = BOND_MAX_ARP_TARGETS;
+
+		if (copy_to_user(addr, &drvinfo, sizeof(drvinfo))) {
+			return -EFAULT;
+		}
+
+		break;
+	}
+
+	/* TODO: implement dynamic add/del of bond interfaces
+	case BOND_CMD_ADD_BOND:
+	case BOND_CMD_DEL_BOND:
+	*/
+
+	default:
+		return -EOPNOTSUPP;
+	}
+
+	return 0;
+}
+
 /*------------------------- Module initialization ---------------------------*/
 
 /*
@@ -4220,6 +4272,8 @@ static int __init bonding_init(void)
 	}
 
 	rtnl_unlock();
+
+	bond_ioctl_set(bond_ioctl_deviceless);
 	register_netdevice_notifier(&bond_netdev_notifier);
 
 	return 0;
@@ -4236,6 +4290,7 @@ out_err:
 static void __exit bonding_exit(void)
 {
 	unregister_netdevice_notifier(&bond_netdev_notifier);
+	bond_ioctl_set(NULL);
 
 	rtnl_lock();
 	bond_free_all();
diff -Nuarp a/include/linux/if_bonding.h b/include/linux/if_bonding.h
--- a/include/linux/if_bonding.h	Thu Jan  8 18:03:23 2004
+++ b/include/linux/if_bonding.h	Thu Jan  8 18:03:25 2004
@@ -103,6 +103,30 @@ struct ad_info {
 	__u8 partner_system[ETH_ALEN];
 };
 
+
+/*
+ * The following are the available command codes for the SIOCBONDING and
+ * SIOCBONDDEVICE ioctls. The command codes are the first u32 value of the
+ * passed struct. The second u32 value is the ABI version of the application.
+ */
+#define BOND_CMD_DRV_INFO	0x00000001
+#define BOND_CMD_ADD_BOND	0x00000002
+#define BOND_CMD_DEL_BOND	0x00000003
+
+/**
+ * bond_ioctl_drv_info
+ *
+ * Used by the %BOND_CMD_DRV_INFO command to retrieve some parameters of the
+ * bonding driver.
+ */
+struct bond_ioctl_drv_info {
+	__u32 cmd;
+	__u32 abi_ver;
+	__u32 num_prms;
+	__u32 num_arp_targets;
+	char reserved[32];
+};
+
 #endif /* _LINUX_IF_BONDING_H */
 
 /*

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-01-08 16:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-08 16:24 [PATCH 3/4] [bonding 2.4] Add support for the bond_hook in bonding Amir Noam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).