* [PATCH] Mark SIOCSIFNAME as compatible ioctl
@ 2004-01-08 7:04 Andi Kleen
2004-01-09 10:04 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Andi Kleen @ 2004-01-08 7:04 UTC (permalink / raw)
To: netdev; +Cc: davem
Mark SIOCSIFNAME as an ioctl that doesn't need 32bit conversion.
Fixes nameif as 32bit executable.
-Andi
diff -X ../KDIFX -burpN linux-vanilla-2.6.1rc2/include/linux/compat_ioctl.h linux-2.6.1rc2-amd64/include/linux/compat_ioctl.h
--- linux-vanilla-2.6.1rc2/include/linux/compat_ioctl.h 2004-01-07 02:36:31.000000000 -0800
+++ linux-2.6.1rc2-amd64/include/linux/compat_ioctl.h 2003-12-31 21:56:55.000000000 -0800
@@ -260,6 +260,7 @@ COMPATIBLE_IOCTL(SIOCATMARK)
COMPATIBLE_IOCTL(SIOCSIFLINK)
COMPATIBLE_IOCTL(SIOCSIFENCAP)
COMPATIBLE_IOCTL(SIOCGIFENCAP)
+COMPATIBLE_IOCTL(SIOCSIFNAME)
COMPATIBLE_IOCTL(SIOCSIFBR)
COMPATIBLE_IOCTL(SIOCGIFBR)
COMPATIBLE_IOCTL(SIOCSARP)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Mark SIOCSIFNAME as compatible ioctl
2004-01-08 7:04 [PATCH] Mark SIOCSIFNAME as compatible ioctl Andi Kleen
@ 2004-01-09 10:04 ` David S. Miller
2004-01-09 15:56 ` Andi Kleen
0 siblings, 1 reply; 4+ messages in thread
From: David S. Miller @ 2004-01-09 10:04 UTC (permalink / raw)
To: Andi Kleen; +Cc: netdev
On Thu, 8 Jan 2004 08:04:13 +0100
Andi Kleen <ak@muc.de> wrote:
> Mark SIOCSIFNAME as an ioctl that doesn't need 32bit conversion.
>
> Fixes nameif as 32bit executable.
How can we mark it compatible? It needs the stuff dev_ifname32() in
fs/compat_ioctl.c does for SIOCGIFNAME doesn't it?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Mark SIOCSIFNAME as compatible ioctl
2004-01-09 10:04 ` David S. Miller
@ 2004-01-09 15:56 ` Andi Kleen
2004-01-13 23:01 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Andi Kleen @ 2004-01-09 15:56 UTC (permalink / raw)
To: David S. Miller; +Cc: ak, netdev
On Fri, 9 Jan 2004 02:04:56 -0800
"David S. Miller" <davem@redhat.com> wrote:
> On Thu, 8 Jan 2004 08:04:13 +0100
> Andi Kleen <ak@muc.de> wrote:
>
> > Mark SIOCSIFNAME as an ioctl that doesn't need 32bit conversion.
> >
> > Fixes nameif as 32bit executable.
>
> How can we mark it compatible? It needs the stuff dev_ifname32() in
> fs/compat_ioctl.c does for SIOCGIFNAME doesn't it?
It takes two strings. This should be compatible:
struct ifreq
{
union
{
char ifrn_name[IFNAMSIZ]; /* if name, e.g. "en0" */
/
} ifr_ifrn;
union {
...
char ifru_newname[IFNAMSIZ];
...
} ifr_ifru;
};
-Andi
P.S.: Maybe it would be time update the "en0" comment in if.h too ;-) I bet that comes from
VAX/BSD.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Mark SIOCSIFNAME as compatible ioctl
2004-01-09 15:56 ` Andi Kleen
@ 2004-01-13 23:01 ` David S. Miller
0 siblings, 0 replies; 4+ messages in thread
From: David S. Miller @ 2004-01-13 23:01 UTC (permalink / raw)
To: Andi Kleen; +Cc: ak, netdev
On Fri, 9 Jan 2004 16:56:27 +0100
Andi Kleen <ak@suse.de> wrote:
> On Fri, 9 Jan 2004 02:04:56 -0800
> "David S. Miller" <davem@redhat.com> wrote:
>
> > How can we mark it compatible? It needs the stuff dev_ifname32() in
> > fs/compat_ioctl.c does for SIOCGIFNAME doesn't it?
>
> It takes two strings. This should be compatible:
You're absolutely right Andi, thanks.
Patch applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-01-13 23:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-08 7:04 [PATCH] Mark SIOCSIFNAME as compatible ioctl Andi Kleen
2004-01-09 10:04 ` David S. Miller
2004-01-09 15:56 ` Andi Kleen
2004-01-13 23:01 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).