From: Stephen Hemminger <shemminger@osdl.org>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH] (11/17) econet -- size_t for send/recvmsg
Date: Fri, 9 Jan 2004 14:03:23 -0800 [thread overview]
Message-ID: <20040109140323.7d48f9db@linux.local> (raw)
Convert econet over to unsigned length for send/recv msg.
Add a bounds check based on device mtu - header.
diff -Nru a/net/econet/af_econet.c b/net/econet/af_econet.c
--- a/net/econet/af_econet.c Mon Dec 8 16:20:01 2003
+++ b/net/econet/af_econet.c Mon Dec 8 16:20:01 2003
@@ -113,11 +113,12 @@
*/
static int econet_recvmsg(struct kiocb *iocb, struct socket *sock,
- struct msghdr *msg, int len, int flags)
+ struct msghdr *msg, size_t len, int flags)
{
struct sock *sk = sock->sk;
struct sk_buff *skb;
- int copied, err;
+ size_t copied;
+ int err;
msg->msg_namelen = sizeof(struct sockaddr_ec);
@@ -246,7 +247,7 @@
*/
static int econet_sendmsg(struct kiocb *iocb, struct socket *sock,
- struct msghdr *msg, int len)
+ struct msghdr *msg, size_t len)
{
struct sock *sk = sock->sk;
struct sockaddr_ec *saddr=(struct sockaddr_ec *)msg->msg_name;
@@ -307,6 +308,9 @@
if (dev == NULL)
return -ENETDOWN;
}
+
+ if (len + 15 > dev->mtu)
+ return -EMSGSIZE;
if (dev->type == ARPHRD_ECONET)
{
reply other threads:[~2004-01-09 22:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040109140323.7d48f9db@linux.local \
--to=shemminger@osdl.org \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).