From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: ak@muc.de, netdev@oss.sgi.com
Subject: Re: [PATCH] Mark SIOCSIFNAME as compatible ioctl
Date: Fri, 9 Jan 2004 16:56:27 +0100 [thread overview]
Message-ID: <20040109165627.2e0845af.ak@suse.de> (raw)
In-Reply-To: <20040109020456.045b447e.davem@redhat.com>
On Fri, 9 Jan 2004 02:04:56 -0800
"David S. Miller" <davem@redhat.com> wrote:
> On Thu, 8 Jan 2004 08:04:13 +0100
> Andi Kleen <ak@muc.de> wrote:
>
> > Mark SIOCSIFNAME as an ioctl that doesn't need 32bit conversion.
> >
> > Fixes nameif as 32bit executable.
>
> How can we mark it compatible? It needs the stuff dev_ifname32() in
> fs/compat_ioctl.c does for SIOCGIFNAME doesn't it?
It takes two strings. This should be compatible:
struct ifreq
{
union
{
char ifrn_name[IFNAMSIZ]; /* if name, e.g. "en0" */
/
} ifr_ifrn;
union {
...
char ifru_newname[IFNAMSIZ];
...
} ifr_ifru;
};
-Andi
P.S.: Maybe it would be time update the "en0" comment in if.h too ;-) I bet that comes from
VAX/BSD.
next prev parent reply other threads:[~2004-01-09 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-08 7:04 [PATCH] Mark SIOCSIFNAME as compatible ioctl Andi Kleen
2004-01-09 10:04 ` David S. Miller
2004-01-09 15:56 ` Andi Kleen [this message]
2004-01-13 23:01 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040109165627.2e0845af.ak@suse.de \
--to=ak@suse.de \
--cc=ak@muc.de \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).