From: Stephen Hemminger <shemminger@osdl.org>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH] support for large number of network devices.
Date: Tue, 13 Jan 2004 15:46:10 -0800 [thread overview]
Message-ID: <20040113154610.38f5934c.shemminger@osdl.org> (raw)
When using pseudo network devices, and really big machines; there is
sometimes a need to have a lot of network devices. This replaces the
existing 2.6.1 limit of 100 entries an was O(n^2)
with a algorithm that will handle up to 32768 entries with O(n) behaviour.
Does need a temporary page, but that shouldn't be a big deal.
It has the same semantics, it will find the first empty name and use it.
diff -Nru a/net/core/dev.c b/net/core/dev.c
--- a/net/core/dev.c Tue Jan 13 15:42:19 2004
+++ b/net/core/dev.c Tue Jan 13 15:42:19 2004
@@ -650,8 +650,11 @@
int dev_alloc_name(struct net_device *dev, const char *name)
{
int i;
- char buf[32];
char *p;
+ const int max_netdevices = 8*PAGE_SIZE;
+ long *inuse;
+ struct net_device *d;
+ char buf[IFNAMSIZ];
/*
* Verify the string as this thing may have come from
@@ -662,17 +665,34 @@
if (p && (p[1] != 'd' || strchr(p + 2, '%')))
return -EINVAL;
- /*
- * If you need over 100 please also fix the algorithm...
- */
- for (i = 0; i < 100; i++) {
- snprintf(buf, sizeof(buf), name, i);
- if (!__dev_get_by_name(buf)) {
- strcpy(dev->name, buf);
- return i;
+ /* Use one page as a bit array of possible slots */
+ inuse = (long *) get_zeroed_page(GFP_ATOMIC);
+ if (!inuse)
+ return -ENOMEM;
+
+ for (d = dev_base; d; d = d->next) {
+ if (sscanf(d->name, name, &i)) {
+ if (i < 0 || i >= max_netdevices)
+ continue;
+
+ set_bit(i, inuse);
}
}
- return -ENFILE; /* Over 100 of the things .. bail out! */
+
+ i = find_first_zero_bit(inuse, max_netdevices);
+ free_page((unsigned long) inuse);
+ snprintf(buf, sizeof(buf), name, i);
+
+ if (!__dev_get_by_name(buf)) {
+ strcpy(dev->name, buf);
+ return i;
+ }
+
+ /* It is possible to run out of possible slots
+ * when the name is long and there isn't enough space left
+ * for the digits, or if all bits are used.
+ */
+ return -ENFILE;
}
next reply other threads:[~2004-01-13 23:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-13 23:46 Stephen Hemminger [this message]
2004-01-13 23:59 ` [PATCH] support for large number of network devices David S. Miller
2004-01-14 0:13 ` Stephen Hemminger
2004-01-14 7:13 ` Matt Mackall
2004-01-14 19:37 ` Stephen Hemminger
2004-01-14 19:51 ` Matt Mackall
2004-01-14 20:11 ` David S. Miller
2004-01-15 0:24 ` Stephen Hemminger
2004-01-15 8:46 ` David S. Miller
2004-01-15 17:52 ` Stephen Hemminger
2004-01-15 19:40 ` David S. Miller
2004-01-14 0:23 ` Ben Greear
2004-01-14 0:38 ` Stephen Hemminger
2004-01-14 1:55 ` Ben Greear
2004-01-14 7:18 ` David S. Miller
2004-01-14 7:54 ` Ben Greear
-- strict thread matches above, loose matches on Subject: below --
2004-01-14 21:39 Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040113154610.38f5934c.shemminger@osdl.org \
--to=shemminger@osdl.org \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).