From: "David S. Miller" <davem@redhat.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] (1/5) replay netdev notifier events on registration
Date: Tue, 13 Jan 2004 16:36:31 -0800 [thread overview]
Message-ID: <20040113163631.1a9c1a59.davem@redhat.com> (raw)
In-Reply-To: <20040113105843.0d1351cb.shemminger@osdl.org>
On Tue, 13 Jan 2004 10:58:43 -0800
Stephen Hemminger <shemminger@osdl.org> wrote:
> Several protocols register for network device notification to detect new new network devices;
> but then have to walk the device list to capture the devices that are already up.
> This leaves a exposed window between when the notifier is registered and when the list walk
> occurs. Also, in several cases, there is a different code path for the pre-existing and
> new devices which leads to bug exposure.
>
> The solution is to replay the registration and up events for existing devices into the
> new notifier.
>
> All notifiers in 2.6.1 have been audited and the other patches fix places
> where protocols were doing there own registered device discovery loop.
>
> Thanks to Al Viro for the suggestion.
Looks good.... are you absolutely sure no remaining notifiers will
barf if they get a register for an already existing device? I know up
events should be ok...
Anyways, I applied all 5 patches, thanks.
next prev parent reply other threads:[~2004-01-14 0:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-13 18:58 [PATCH] (1/5) replay netdev notifier events on registration Stephen Hemminger
2004-01-14 0:36 ` David S. Miller [this message]
2004-01-15 0:40 ` [PATCH] decnet initialization race Stephen Hemminger
2004-01-15 8:45 ` David S. Miller
2004-01-15 0:43 ` [PATH] atm/clip device discovery on init not needed Stephen Hemminger
2004-01-15 8:44 ` David S. Miller
2004-01-15 22:59 ` Stephen Hemminger
2004-01-15 23:00 ` David S. Miller
2004-01-15 0:44 ` [PATCH] (1/5) replay netdev notifier events on registration Stephen Hemminger
2004-01-15 8:42 ` David S. Miller
2004-01-15 18:16 ` Stephen Hemminger
2004-01-15 19:51 ` David S. Miller
2004-01-16 3:19 ` chas williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040113163631.1a9c1a59.davem@redhat.com \
--to=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).