From: Matt Mackall <mpm@selenic.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "David S. Miller" <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: [PATCH] support for large number of network devices.
Date: Wed, 14 Jan 2004 13:51:57 -0600 [thread overview]
Message-ID: <20040114195157.GJ28521@waste.org> (raw)
In-Reply-To: <20040114113734.4e9a0865.shemminger@osdl.org>
On Wed, Jan 14, 2004 at 11:37:34AM -0800, Stephen Hemminger wrote:
>
> > Unfortunately sscanf("eth0-not-allocated", "eth%d", &i) fools it.
> > Which may or may not be worth worrying about.
>
> Hmmm, the old code would have assigned "eth0" in that case, new code
> would assign "eth1". Other difference is in the case of whitespace.
> scanf("white space0", "white space%d", &i)
> because any whitespace matches multiple whitespace characters.
>
> Is it worth making a separate explicit match routine?
I think it's probably easier to just add O(1) lookup and then do
explicit lookups on eth0..ethx. As Dave's pointed out, fast lookups
are wanted elsewhere. I made a quick hack to make the sscanf trick
work (try scanning for "eth%d%c" and insisting that %c not get parsed)
but it was not pretty.
--
Matt Mackall : http://www.selenic.com : Linux development and consulting
next prev parent reply other threads:[~2004-01-14 19:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-13 23:46 [PATCH] support for large number of network devices Stephen Hemminger
2004-01-13 23:59 ` David S. Miller
2004-01-14 0:13 ` Stephen Hemminger
2004-01-14 7:13 ` Matt Mackall
2004-01-14 19:37 ` Stephen Hemminger
2004-01-14 19:51 ` Matt Mackall [this message]
2004-01-14 20:11 ` David S. Miller
2004-01-15 0:24 ` Stephen Hemminger
2004-01-15 8:46 ` David S. Miller
2004-01-15 17:52 ` Stephen Hemminger
2004-01-15 19:40 ` David S. Miller
2004-01-14 0:23 ` Ben Greear
2004-01-14 0:38 ` Stephen Hemminger
2004-01-14 1:55 ` Ben Greear
2004-01-14 7:18 ` David S. Miller
2004-01-14 7:54 ` Ben Greear
-- strict thread matches above, loose matches on Subject: below --
2004-01-14 21:39 Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040114195157.GJ28521@waste.org \
--to=mpm@selenic.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).