From: Chris Wright <chrisw@osdl.org>
To: maximilian attems <janitor@sternwelten.at>
Cc: Chris Wright <chrisw@osdl.org>, netdev@oss.sgi.com
Subject: Re: [PATCH 1/5] tun check error on memcpy_fromiovec
Date: Fri, 16 Jan 2004 16:45:12 -0800 [thread overview]
Message-ID: <20040116164512.C19034@osdlab.pdx.osdl.net> (raw)
In-Reply-To: <20031219103457.GD1213@mail.sternwelten.at>; from janitor@sternwelten.at on Fri, Dec 19, 2003 at 11:34:58AM +0100
* maximilian attems (janitor@sternwelten.at) wrote:
> hey chris,
>
> after applying your 4 patches on top of linux-2.6.0
> + experimental net,
> found 2 last unchecked memcpy_fromiovec in tun.c
> patch bellow fixes the second call,
> the first is beyond me, please complete this patch :)
> compile tested
I specifically left those alone. They have a semi-bogus verify_area()
call that is trying to insure the memcpy_fromiovec won't EFAULT. I'd
prefer to remove them and simply do memcpy checking.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2004-01-17 0:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 4:23 [PATCH 1/4] ax25 check error on memcpy_fromiovec Chris Wright
2003-12-09 4:24 ` [PATCH 2/4] irda " Chris Wright
2003-12-09 4:25 ` [PATCH 3/4] netrom " Chris Wright
2003-12-09 4:27 ` [PATCH 4/4] rose " Chris Wright
2003-12-09 5:39 ` [PATCH 1/4] ax25 " David S. Miller
2003-12-09 5:41 ` Chris Wright
2003-12-19 10:34 ` [PATCH 1/5] tun " maximilian attems
2003-12-19 14:23 ` Jeff Garzik
2004-01-17 0:45 ` Chris Wright [this message]
2004-01-21 20:49 ` Max Krasnyansky
2004-01-23 2:13 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040116164512.C19034@osdlab.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=janitor@sternwelten.at \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).