From: Andrew Morton <akpm@osdl.org>
To: Jim Keniston <jkenisto@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
jgarzik@pobox.com, jkenisto@us.ibm.com, scott.feldman@intel.com,
kessler@us.ibm.com
Subject: Re: [PATCH 2.6.1] Net device error logging
Date: Mon, 19 Jan 2004 18:46:30 -0800 [thread overview]
Message-ID: <20040119184630.5d066735.akpm@osdl.org> (raw)
In-Reply-To: <400C3D3E.BFCC25CE@us.ibm.com>
Jim Keniston <jkenisto@us.ibm.com> wrote:
>
> The enclosed patch implements the netdev_* error-logging macros for
> network drivers.
Looks OK to me.
But it does make one wonder whether we'll soon see standalone patches for
scsi_printk(), pci_bridge_printk(), random_other_subsystem_printk(), ...?
Or is it intended that the backend logging code will be implemented mainly
in terms of the `struct device'? So netdev_printk() will be a bit of
netdev-specific boilerplate which then calls into a more generic
device_printk()?
next prev parent reply other threads:[~2004-01-20 2:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-19 20:25 [PATCH 2.6.1] Net device error logging Jim Keniston
2004-01-20 2:46 ` Andrew Morton [this message]
2004-01-20 23:19 ` Jim Keniston
2004-01-20 18:51 ` Rask Ingemann Lambertsen
2004-01-20 23:06 ` Jim Keniston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040119184630.5d066735.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=jkenisto@us.ibm.com \
--cc=kessler@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).