From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH] more improvement to dev_alloc_name -- strnchr Date: Mon, 19 Jan 2004 21:06:05 +0100 Sender: netdev-bounce@oss.sgi.com Message-ID: <20040119210605.3cea32b0.ak@suse.de> References: <1074302619.40088e9bd44a6@www.geekmail.cc> <20040119113204.5913a8d6.shemminger@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@redhat.com, ap@cipherica.com, netdev@oss.sgi.com Return-path: To: Stephen Hemminger In-Reply-To: <20040119113204.5913a8d6.shemminger@osdl.org> Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Mon, 19 Jan 2004 11:32:04 -0800 Stephen Hemminger wrote: > +#ifndef __HAVE_ARCH_STRNCHR Please drop the ifdef. Don't want to encourage anybody to write strrchr() in assembly. -Andi