From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: jamagallon@able.es, linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: 2.6.1-mm4
Date: Mon, 19 Jan 2004 22:42:19 +1100 [thread overview]
Message-ID: <20040119224219.65991501.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20040118001708.09291455.akpm@osdl.org>
On Sun, 18 Jan 2004 00:17:08 -0800
Andrew Morton <akpm@osdl.org> wrote:
> Presumably, recent gcc's remove the variable altogether and just expand the
> constant inline. When the central module code checks for the parameter's
> existence in the module's symbol table it errors out.
MODULE_PARM considered harmful.
Unfortunately, there's no easy way of fixing this, since MODULE_PARM()
is often used on variables which aren't declared yet 8(. (I tried this
in an early patch).
Migrating to module_param() is the Right Thing here IMHO, which actually
takes the damn address,
Rusty.
--
there are those who do and those who hang on and you don't see too
many doers quoting their contemporaries. -- Larry McVoy
prev parent reply other threads:[~2004-01-19 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040115225948.6b994a48.akpm@osdl.org>
2004-01-18 0:12 ` 2.6.1-mm4 J.A. Magallon
2004-01-18 5:55 ` 2.6.1-mm4 Andrew Morton
2004-01-18 8:11 ` 2.6.1-mm4 J.A. Magallon
2004-01-18 8:17 ` 2.6.1-mm4 Andrew Morton
2004-01-19 11:42 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040119224219.65991501.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).