From: Stephen Hemminger <shemminger@osdl.org>
To: "YOSHIFUJI Hideaki / ____________" <yoshfuji@linux-ipv6.org>
Cc: davem@redhat.com, yoshfuji@linux-ipv6.org, netdev@oss.sgi.com
Subject: Re: [PATCH] IPV6: add missing sentinel for addrconf procfs
Date: Tue, 20 Jan 2004 10:48:20 -0800 [thread overview]
Message-ID: <20040120104820.77ff135f.shemminger@osdl.org> (raw)
In-Reply-To: <20040120.094223.76534381.yoshfuji@linux-ipv6.org>
On Tue, 20 Jan 2004 09:42:23 +0900 (JST)
YOSHIFUJI Hideaki / ____________ <yoshfuji@linux-ipv6.org> wrote:
> Sorry, I forgot to increase the number of members in the array and
> that the sentinel was removed.
> So, add missing sentinel explicitly.
How about adding all them explicitly to prevent future errors?
diff -Nru a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
--- a/net/ipv6/addrconf.c Tue Jan 20 10:51:20 2004
+++ b/net/ipv6/addrconf.c Tue Jan 20 10:51:20 2004
@@ -3191,6 +3191,9 @@
.mode = 0555,
.child = addrconf_sysctl.addrconf_vars,
},
+ {
+ .ctl_name = 0, /* sentinel */
+ }
},
.addrconf_conf_dir = {
{
@@ -3199,6 +3202,9 @@
.mode = 0555,
.child = addrconf_sysctl.addrconf_dev,
},
+ {
+ .ctl_name = 0, /* sentinel */
+ }
},
.addrconf_proto_dir = {
{
@@ -3207,6 +3213,9 @@
.mode = 0555,
.child = addrconf_sysctl.addrconf_conf_dir,
},
+ {
+ .ctl_name = 0, /* sentinel */
+ }
},
.addrconf_root_dir = {
{
@@ -3215,6 +3224,9 @@
.mode = 0555,
.child = addrconf_sysctl.addrconf_proto_dir,
},
+ {
+ .ctl_name = 0, /* sentinel */
+ }
},
};
next prev parent reply other threads:[~2004-01-20 18:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-20 0:42 [PATCH] IPV6: add missing sentinel for addrconf procfs YOSHIFUJI Hideaki / 吉藤英明
2004-01-20 4:55 ` David S. Miller
2004-01-20 18:48 ` Stephen Hemminger [this message]
2004-01-21 2:30 ` YOSHIFUJI Hideaki / 吉藤英明
2004-01-22 6:11 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040120104820.77ff135f.shemminger@osdl.org \
--to=shemminger@osdl.org \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).