* [PATCH] IPV6: add missing sentinel for addrconf procfs
@ 2004-01-20 0:42 YOSHIFUJI Hideaki / 吉藤英明
2004-01-20 4:55 ` David S. Miller
2004-01-20 18:48 ` Stephen Hemminger
0 siblings, 2 replies; 5+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2004-01-20 0:42 UTC (permalink / raw)
To: davem; +Cc: yoshfuji, netdev
Sorry, I forgot to increase the number of members in the array and
that the sentinel was removed.
So, add missing sentinel explicitly.
===== net/ipv6/addrconf.c 1.85 vs edited =====
--- 1.85/net/ipv6/addrconf.c Fri Jan 16 19:05:24 2004
+++ edited/net/ipv6/addrconf.c Tue Jan 20 09:34:19 2004
@@ -3039,7 +3039,7 @@
static struct addrconf_sysctl_table
{
struct ctl_table_header *sysctl_header;
- ctl_table addrconf_vars[16];
+ ctl_table addrconf_vars[17];
ctl_table addrconf_dev[2];
ctl_table addrconf_conf_dir[2];
ctl_table addrconf_proto_dir[2];
@@ -3180,6 +3180,9 @@
.mode = 0644,
.proc_handler = &proc_dointvec,
},
+ {
+ .ctl_name = 0, /* sentinel */
+ }
},
.addrconf_dev = {
{
--
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] IPV6: add missing sentinel for addrconf procfs 2004-01-20 0:42 [PATCH] IPV6: add missing sentinel for addrconf procfs YOSHIFUJI Hideaki / 吉藤英明 @ 2004-01-20 4:55 ` David S. Miller 2004-01-20 18:48 ` Stephen Hemminger 1 sibling, 0 replies; 5+ messages in thread From: David S. Miller @ 2004-01-20 4:55 UTC (permalink / raw) To: YOSHIFUJI Hideaki / _$B5HF#1QL@; +Cc: yoshfuji, netdev On Tue, 20 Jan 2004 09:42:23 +0900 (JST) YOSHIFUJI Hideaki / _$B5HF#1QL@ <yoshfuji@linux-ipv6.org> wrote: > Sorry, I forgot to increase the number of members in the array and > that the sentinel was removed. > So, add missing sentinel explicitly. Applied, thanks yoshfuji. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] IPV6: add missing sentinel for addrconf procfs 2004-01-20 0:42 [PATCH] IPV6: add missing sentinel for addrconf procfs YOSHIFUJI Hideaki / 吉藤英明 2004-01-20 4:55 ` David S. Miller @ 2004-01-20 18:48 ` Stephen Hemminger 2004-01-21 2:30 ` YOSHIFUJI Hideaki / 吉藤英明 2004-01-22 6:11 ` David S. Miller 1 sibling, 2 replies; 5+ messages in thread From: Stephen Hemminger @ 2004-01-20 18:48 UTC (permalink / raw) To: YOSHIFUJI Hideaki / ____________; +Cc: davem, yoshfuji, netdev On Tue, 20 Jan 2004 09:42:23 +0900 (JST) YOSHIFUJI Hideaki / ____________ <yoshfuji@linux-ipv6.org> wrote: > Sorry, I forgot to increase the number of members in the array and > that the sentinel was removed. > So, add missing sentinel explicitly. How about adding all them explicitly to prevent future errors? diff -Nru a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c --- a/net/ipv6/addrconf.c Tue Jan 20 10:51:20 2004 +++ b/net/ipv6/addrconf.c Tue Jan 20 10:51:20 2004 @@ -3191,6 +3191,9 @@ .mode = 0555, .child = addrconf_sysctl.addrconf_vars, }, + { + .ctl_name = 0, /* sentinel */ + } }, .addrconf_conf_dir = { { @@ -3199,6 +3202,9 @@ .mode = 0555, .child = addrconf_sysctl.addrconf_dev, }, + { + .ctl_name = 0, /* sentinel */ + } }, .addrconf_proto_dir = { { @@ -3207,6 +3213,9 @@ .mode = 0555, .child = addrconf_sysctl.addrconf_conf_dir, }, + { + .ctl_name = 0, /* sentinel */ + } }, .addrconf_root_dir = { { @@ -3215,6 +3224,9 @@ .mode = 0555, .child = addrconf_sysctl.addrconf_proto_dir, }, + { + .ctl_name = 0, /* sentinel */ + } }, }; ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] IPV6: add missing sentinel for addrconf procfs 2004-01-20 18:48 ` Stephen Hemminger @ 2004-01-21 2:30 ` YOSHIFUJI Hideaki / 吉藤英明 2004-01-22 6:11 ` David S. Miller 1 sibling, 0 replies; 5+ messages in thread From: YOSHIFUJI Hideaki / 吉藤英明 @ 2004-01-21 2:30 UTC (permalink / raw) To: shemminger; +Cc: davem, netdev, yoshfuji In article <20040120104820.77ff135f.shemminger@osdl.org> (at Tue, 20 Jan 2004 10:48:20 -0800), Stephen Hemminger <shemminger@osdl.org> says: > > Sorry, I forgot to increase the number of members in the array and > > that the sentinel was removed. > > So, add missing sentinel explicitly. > > How about adding all them explicitly to prevent future errors? agreed. --yoshfuji ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] IPV6: add missing sentinel for addrconf procfs 2004-01-20 18:48 ` Stephen Hemminger 2004-01-21 2:30 ` YOSHIFUJI Hideaki / 吉藤英明 @ 2004-01-22 6:11 ` David S. Miller 1 sibling, 0 replies; 5+ messages in thread From: David S. Miller @ 2004-01-22 6:11 UTC (permalink / raw) To: Stephen Hemminger; +Cc: yoshfuji, netdev On Tue, 20 Jan 2004 10:48:20 -0800 Stephen Hemminger <shemminger@osdl.org> wrote: > On Tue, 20 Jan 2004 09:42:23 +0900 (JST) > YOSHIFUJI Hideaki / ____________ <yoshfuji@linux-ipv6.org> wrote: > > > Sorry, I forgot to increase the number of members in the array and > > that the sentinel was removed. > > So, add missing sentinel explicitly. > > How about adding all them explicitly to prevent future errors? Applied, thanks Stephen. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-01-22 6:11 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2004-01-20 0:42 [PATCH] IPV6: add missing sentinel for addrconf procfs YOSHIFUJI Hideaki / 吉藤英明 2004-01-20 4:55 ` David S. Miller 2004-01-20 18:48 ` Stephen Hemminger 2004-01-21 2:30 ` YOSHIFUJI Hideaki / 吉藤英明 2004-01-22 6:11 ` David S. Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).