From: Willy Tarreau <willy@w.ods.org>
To: marcelo.tosatti@cyclades.com
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: [PATCH-2.4] add missing '\n' in bonding messages
Date: Wed, 28 Jan 2004 14:04:56 +0100 [thread overview]
Message-ID: <20040128130456.GA12362@alpha.home.local> (raw)
Hi,
there are a few places where the bonding driver displays informational
messages without the trailing '\n', which is sometimes annoying because
messages get logged at the wrong level.
Here's the patch against 2.4.25-pre7. I haven't checked 2.6 nor the bonding
cleanup patch against those typos.
Regards,
Willy
diff -urN linux-2.4.25-pre7/drivers/net/bonding/bond_main.c linux-2.4.25-pre7-bondfix/drivers/net/bonding/bond_main.c
--- linux-2.4.25-pre7/drivers/net/bonding/bond_main.c Sat Nov 22 16:55:37 2003
+++ linux-2.4.25-pre7-bondfix/drivers/net/bonding/bond_main.c Wed Jan 28 13:58:22 2004
@@ -1712,7 +1712,7 @@
* all 0's.
*/
#ifdef BONDING_DEBUG
- printk(KERN_DEBUG "%s doesn't have a MAC address yet. ",
+ printk(KERN_DEBUG "%s doesn't have a MAC address yet.\n",
master_dev->name);
printk(KERN_DEBUG "Going to give assign it from %s.\n",
slave_dev->name);
@@ -2311,7 +2311,7 @@
printk(KERN_INFO
"%s: link status definitely down "
- "for interface %s, disabling it",
+ "for interface %s, disabling it.\n",
master->name,
dev->name);
@@ -2524,7 +2524,7 @@
if (oldcurrent == NULL) {
printk(KERN_INFO
"%s: link status definitely up "
- "for interface %s, ",
+ "for interface %s.\n",
master->name,
slave->dev->name);
do_failover = 1;
@@ -2733,7 +2733,7 @@
slave->link_failure_count++;
}
printk(KERN_INFO "%s: link status down for "
- "active interface %s, disabling it",
+ "active interface %s, disabling it.\n",
master->name,
slave->dev->name);
write_lock(&bond->ptrlock);
@@ -4101,7 +4101,7 @@
if (max_bonds < 1 || max_bonds > INT_MAX) {
printk(KERN_WARNING
"bonding_init(): max_bonds (%d) not in range %d-%d, "
- "so it was reset to BOND_DEFAULT_MAX_BONDS (%d)",
+ "so it was reset to BOND_DEFAULT_MAX_BONDS (%d)\n",
max_bonds, 1, INT_MAX, BOND_DEFAULT_MAX_BONDS);
max_bonds = BOND_DEFAULT_MAX_BONDS;
}
next reply other threads:[~2004-01-28 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-28 13:04 Willy Tarreau [this message]
[not found] <E791C176A6139242A988ABA8B3D9B38A03A9CCD3@hasmsx403.iil.intel.com>
2004-01-28 13:23 ` [PATCH-2.4] add missing '\n' in bonding messages Shmuel Hen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040128130456.GA12362@alpha.home.local \
--to=willy@w.ods.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).