[PATCH 1/2] IPV6: use ipv6_addr_any()

[PATCH 1/2] IPV6: use ipv6_addr_any()

[YOSHIFUJI Hideaki / 吉藤英明]

Hello.

Use simple ipv6_addr_any()
where ipv6_addr_type() is called only to check for unspecified address.

Thanks.

===== net/ipv6/af_inet6.c 1.60 vs edited =====
--- 1.60/net/ipv6/af_inet6.c	Thu Jan 22 15:38:40 2004
+++ edited/net/ipv6/af_inet6.c	Wed Jan 28 16:11:31 2004
@@ -464,7 +464,7 @@
 		if (np->sndflow)
 			sin->sin6_flowinfo = np->flow_label;
 	} else {
-		if (ipv6_addr_type(&np->rcv_saddr) == IPV6_ADDR_ANY)
+		if (ipv6_addr_any(&np->rcv_saddr))
 			ipv6_addr_copy(&sin->sin6_addr, &np->saddr);
 		else
 			ipv6_addr_copy(&sin->sin6_addr, &np->rcv_saddr);
===== net/ipv6/ndisc.c 1.64 vs edited =====
--- 1.64/net/ipv6/ndisc.c	Thu Jan 22 15:38:40 2004
+++ edited/net/ipv6/ndisc.c	Wed Jan 28 16:13:21 2004
@@ -544,7 +544,7 @@
 	}
 
 	len = sizeof(struct icmp6hdr) + sizeof(struct in6_addr);
-	send_llinfo = dev->addr_len && ipv6_addr_type(saddr) != IPV6_ADDR_ANY;
+	send_llinfo = dev->addr_len && !ipv6_addr_any(saddr);
 	if (send_llinfo)
 		len += NDISC_OPT_SPACE(dev->addr_len);
 

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

Re: [PATCH 1/2] IPV6: use ipv6_addr_any()

[Pekka Savola]

On Wed, 28 Jan 2004, YOSHIFUJI Hideaki / [iso-2022-jp] ^[$B5HF#1QL@^[(B wrote:
> Use simple ipv6_addr_any()
> where ipv6_addr_type() is called only to check for unspecified address.

Speakign of which, should it be better to change this to _unspecified
if we're changing this as one could be led to believe that "any"  
refers to "any IPv6 address" which is obviously not the case.

> ===== net/ipv6/af_inet6.c 1.60 vs edited =====
> --- 1.60/net/ipv6/af_inet6.c	Thu Jan 22 15:38:40 2004
> +++ edited/net/ipv6/af_inet6.c	Wed Jan 28 16:11:31 2004
> @@ -464,7 +464,7 @@
>  		if (np->sndflow)
>  			sin->sin6_flowinfo = np->flow_label;
>  	} else {
> -		if (ipv6_addr_type(&np->rcv_saddr) == IPV6_ADDR_ANY)
> +		if (ipv6_addr_any(&np->rcv_saddr))
>  			ipv6_addr_copy(&sin->sin6_addr, &np->saddr);
>  		else
>  			ipv6_addr_copy(&sin->sin6_addr, &np->rcv_saddr);
> ===== net/ipv6/ndisc.c 1.64 vs edited =====
> --- 1.64/net/ipv6/ndisc.c	Thu Jan 22 15:38:40 2004
> +++ edited/net/ipv6/ndisc.c	Wed Jan 28 16:13:21 2004
> @@ -544,7 +544,7 @@
>  	}
>  
>  	len = sizeof(struct icmp6hdr) + sizeof(struct in6_addr);
> -	send_llinfo = dev->addr_len && ipv6_addr_type(saddr) != IPV6_ADDR_ANY;
> +	send_llinfo = dev->addr_len && !ipv6_addr_any(saddr);
>  	if (send_llinfo)
>  		len += NDISC_OPT_SPACE(dev->addr_len);
>  
> 
> 

-- 
Pekka Savola                 "You each name yourselves king, yet the
Netcore Oy                    kingdom bleeds."
Systems. Networks. Security. -- George R.R. Martin: A Clash of Kings

Re: [PATCH 1/2] IPV6: use ipv6_addr_any()

[YOSHIFUJI Hideaki / 吉藤英明]

In article <Pine.LNX.4.44.0401281256260.21205-100000@netcore.fi> (at Wed, 28 Jan 2004 12:57:27 +0200 (EET)), Pekka Savola <pekkas@netcore.fi> says:

> On Wed, 28 Jan 2004, YOSHIFUJI Hideaki / [iso-2022-jp] ^[$B5HF#1QL@^[(B wrote:
> > Use simple ipv6_addr_any()
> > where ipv6_addr_type() is called only to check for unspecified address.
> 
> Speakign of which, should it be better to change this to _unspecified
> if we're changing this as one could be led to believe that "any"  
> refers to "any IPv6 address" which is obviously not the case.

I don't think we need to change the name for now.
It however should be done by another patch 
if it is better to be changed.

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

Re: [PATCH 1/2] IPV6: use ipv6_addr_any()

[David S. Miller]

On Wed, 28 Jan 2004 16:30:43 +0900 (JST)
YOSHIFUJI Hideaki / ^[$B5HF#1QL@^[(B <yoshfuji@linux-ipv6.org> wrote:

> Use simple ipv6_addr_any()
> where ipv6_addr_type() is called only to check for unspecified address.

Applied.  Arigato Yoshfuji-san.