Hi I was studying the linux 2.6.1 networking code (via lxr.linux.no) and stumbled on three minor points. 1. fib_props[] in net/ipv4/fib_semantics.c has size determined by RTA_MAX, yet is indexed by RTN_* constants. Patch included. 2. Two typos ("xrfm") in comments in include/net/xfrm.h. Patch included. 3. I'm quite new to all this, so I might be missing something, but I think a dependency is reversed. net/sched/Kconfig says: config NET_CLS_ROUTE bool depends on NET_CLS_ROUTE4 default y Yet evidence seems to indicate NET_CLS_ROUTE4 actually depends on NET_CLS_ROUTE instead: net/sched/Makefile:29:obj-$(CONFIG_NET_CLS_ROUTE4) += cls_route.o net/sched/cls_route.c:153: id = dst->tclassid; include/net/dst.h:72:#ifdef CONFIG_NET_CLS_ROUTE include/net/dst.h:73: __u32 tclassid; include/net/dst.h:74:#endif Linux 2.4.22's net/sched/Config.in also seems to support this direction of the dependency. regards, -- Matthijs van Duin -- May the Forth be with you!