netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patchlet 2.6 iucv
@ 2004-02-03  4:12 Pete Zaitcev
  0 siblings, 0 replies; only message in thread
From: Pete Zaitcev @ 2004-02-03  4:12 UTC (permalink / raw)
  To: schwidefsky; +Cc: netdev

Hi, Martin,

it seems that someone misused container_of. Spotted by Al Viro.
Please pass to whoever is responsible for IUCV.

-- Pete

--- linux-2.6.1/drivers/s390/net/netiucv.c	2003-10-01 15:17:54.000000000 -0700
+++ linux-2.6.1-s390/drivers/s390/net/netiucv.c	2004-02-02 19:59:11.000000000 -0800
@@ -1258,8 +1258,7 @@
 buffer_write (struct device *dev, const char *buf, size_t count)
 {
 	struct netiucv_priv *priv = dev->driver_data;
-	struct net_device *ndev =
-		container_of((void *)priv, struct net_device, priv);
+	struct net_device *ndev = priv->conn->netdev;
 	char         *e;
 	int          bs1;
 	char         tmp[CTRL_BUFSIZE];

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-02-03  4:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-03  4:12 Patchlet 2.6 iucv Pete Zaitcev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).