From: Willy Tarreau <willy@w.ods.org>
To: David Stevens <dlstevens@us.ibm.com>
Cc: "David S. Miller" <davem@redhat.com>,
netdev@oss.sgi.com, jgarzik@pobox.com,
Alexandre.Cassen@wanadoo.fr
Subject: Re: Deadlock problem with dev->refcnt somewhere in netlink/multicast... [PATCH]
Date: Tue, 3 Feb 2004 07:00:48 +0100 [thread overview]
Message-ID: <20040203060048.GA3531@alpha.home.local> (raw)
In-Reply-To: <OFDBAB37F5.227951E9-ON88256E2E.0080F5BF@us.ibm.com>
Hi David,
On Mon, Feb 02, 2004 at 04:41:11PM -0700, David Stevens wrote:
> Below is a patch for the reference count problem you ran into.
>
> The problem is that the IGMP code was using "IFF_UP" to determine
> if a report should be sent or a timer should be started. But it is not
> necessarily cleared during a destroy_dev.
>
> The IPv4 code was also missing an ip_mc_down() call added in the
> IPv6 code for a similar case by Jan Oravec.
I would never have found this myself !
> The patch is for 2.4.x but also applies to 2.6.x. In-line for
> whitespace-mangled
> viewing and attached for applying.
>
> Thanks for reporting the problem, Willy, and let me know if you have any
> problems with the patch.
Thanks a lot, I will try ASAP and will report if I still can break it.
Cheers,
Willy
next prev parent reply other threads:[~2004-02-03 6:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-02 23:41 Deadlock problem with dev->refcnt somewhere in netlink/multicast... [PATCH] David Stevens
2004-02-02 23:47 ` David S. Miller
2004-02-03 6:00 ` Willy Tarreau [this message]
2004-02-05 18:21 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040203060048.GA3531@alpha.home.local \
--to=willy@w.ods.org \
--cc=Alexandre.Cassen@wanadoo.fr \
--cc=davem@redhat.com \
--cc=dlstevens@us.ibm.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).