[PATCH] IPV6: fix a possible dst leakage in ndisc_send

netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] IPV6: fix a possible dst leakage in ndisc_send_redirect()
@ 2004-02-03  7:27 YOSHIFUJI Hideaki / 吉藤英明
  2004-02-03 17:18 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2004-02-03  7:27 UTC (permalink / raw)
  To: davem; +Cc: netdev, yoshfuji

Hello.

D: fix a dst leakage in error path in ndisc_send_redirect().

Thanks.

===== net/ipv6/ndisc.c 1.64 vs edited =====
--- 1.64/net/ipv6/ndisc.c	Thu Jan 22 15:38:40 2004
+++ edited/net/ipv6/ndisc.c	Tue Feb  3 16:18:36 2004
@@ -1365,6 +1365,7 @@
 				   1, &err);
 	if (buff == NULL) {
 		ND_PRINTK1("ndisc_send_redirect: alloc_skb failed\n");
+		dst_release(dst);
 		return;
 	}
 

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] IPV6: fix a possible dst leakage in ndisc_send_redirect()
  2004-02-03  7:27 [PATCH] IPV6: fix a possible dst leakage in ndisc_send_redirect() YOSHIFUJI Hideaki / 吉藤英明
@ 2004-02-03 17:18 ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-02-03 17:18 UTC (permalink / raw)
  To: yoshfuji; +Cc: netdev

On Tue, 03 Feb 2004 16:27:54 +0900 (JST)
YOSHIFUJI Hideaki / ^[$B5HF#1QL@^[(B <yoshfuji@linux-ipv6.org> wrote:

> D: fix a dst leakage in error path in ndisc_send_redirect().

Applied.  An eventual cleanup of this function would be to consolidate
all of these paths into a single:

dst_out:
	dst_release(dst);
	return;

near the end of the function that all these spots can jump to.

But it's not so important.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-02-03 17:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-03  7:27 [PATCH] IPV6: fix a possible dst leakage in ndisc_send_redirect() YOSHIFUJI Hideaki / 吉藤英明
2004-02-03 17:18 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).