From: "David S. Miller" <davem@redhat.com>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: steve@navaho.co.uk, netdev@oss.sgi.com,
netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] fix netfilter refcounting [was Re: Conntrack leak (2.6.2rc2)]
Date: Tue, 3 Feb 2004 09:48:08 -0800 [thread overview]
Message-ID: <20040203094808.2bb3640a.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0402031825170.11950-100000@blackhole.kfki.hu>
On Tue, 3 Feb 2004 18:43:38 +0100 (CET)
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> wrote:
> Steve Hill reported a conntrack leakage in 2.6.2-rc2 when nat is enabled
> and the system forwards fragmented packets. It turned out that an
> nf_conntrack_put was missing from ip_copy_metadata:
Yeah, but... look at what you patched.
> /* Connection association is same as pre-frag packet */
> + nf_conntrack_put(to->nfct);
> to->nfct = from->nfct;
> nf_conntrack_get(to->nfct);
What about that comment?
next prev parent reply other threads:[~2004-02-03 17:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-02 8:56 Conntrack leak (2.6.2rc2) Steve Hill
2004-02-02 9:22 ` Jozsef Kadlecsik
2004-02-02 9:46 ` Steve Hill
2004-02-02 10:34 ` Jozsef Kadlecsik
2004-02-02 10:48 ` Steve Hill
2004-02-02 11:45 ` Jozsef Kadlecsik
2004-02-02 11:58 ` Steve Hill
2004-02-02 12:47 ` Jozsef Kadlecsik
2004-02-02 13:36 ` Steve Hill
2004-02-02 13:46 ` Jozsef Kadlecsik
2004-02-02 14:03 ` Steve Hill
2004-02-03 8:14 ` Andi Kleen
2004-02-03 8:48 ` Jozsef Kadlecsik
2004-02-03 14:35 ` Steve Hill
2004-02-03 15:32 ` Jozsef Kadlecsik
2004-02-03 17:43 ` [PATCH] fix netfilter refcounting [was Re: Conntrack leak (2.6.2rc2)] Jozsef Kadlecsik
2004-02-03 17:48 ` David S. Miller [this message]
2004-02-03 18:27 ` David S. Miller
2004-02-04 10:19 ` Steve Hill
2004-02-04 9:20 ` Conntrack leak (2.6.2rc2) Harald Welte
2004-02-04 9:22 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040203094808.2bb3640a.davem@redhat.com \
--to=davem@redhat.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=netdev@oss.sgi.com \
--cc=netfilter-devel@lists.netfilter.org \
--cc=steve@navaho.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).