* [PATCH] IPV6: note on shared socket options
@ 2004-02-04 11:37 YOSHIFUJI Hideaki / 吉藤英明
2004-02-04 21:49 ` David Stevens
2004-02-05 7:21 ` David S. Miller
0 siblings, 2 replies; 6+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2004-02-04 11:37 UTC (permalink / raw)
To: davem; +Cc: yoshfuji, netdev
Hello.
There're several socket options for multicast
shared between IPv4 and IPv6.
Add a note that some range is already used for them.
(Alternatevely, we could define other names like this:
#define IPV6_MCAST_JOIN_GROUP MCAST_JOIN_GROUP
#define IPV6_MCAST_BLOCK_SOURCE MCAST_BLOCK_SOURCE
/* bla, bla ... */
)
===== include/linux/in6.h 1.5 vs edited =====
--- 1.5/include/linux/in6.h Fri Mar 21 14:23:30 2003
+++ edited/include/linux/in6.h Wed Feb 4 20:30:47 2004
@@ -183,5 +183,17 @@
#define IPV6_IPSEC_POLICY 34
#define IPV6_XFRM_POLICY 35
+/*
+ * Multicast:
+ * Following socket options are shared between IPv4 and IPv6.
+ *
+ * MCAST_JOIN_GROUP 42
+ * MCAST_BLOCK_SOURCE 43
+ * MCAST_UNBLOCK_SOURCE 44
+ * MCAST_LEAVE_GROUP 45
+ * MCAST_JOIN_SOURCE_GROUP 46
+ * MCAST_LEAVE_SOURCE_GROUP 47
+ * MCAST_MSFILTER 48
+ */
#endif
--
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] IPV6: note on shared socket options
2004-02-04 11:37 [PATCH] IPV6: note on shared socket options YOSHIFUJI Hideaki / 吉藤英明
@ 2004-02-04 21:49 ` David Stevens
2004-02-05 2:09 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-05 6:25 ` Pekka Savola
2004-02-05 7:21 ` David S. Miller
1 sibling, 2 replies; 6+ messages in thread
From: David Stevens @ 2004-02-04 21:49 UTC (permalink / raw)
To: YOSHIFUJI Hideaki / 吉藤英明
Cc: davem, yoshfuji, netdev
[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]
Yoshifuji-san,
These are defined by draft-ietf-magma-msf-api-03.txt to be in
netinet/in.h (no place else). What's the advantage of adding another
copy in in6.h (which currently isn't used by anything)? Portable user apps
must include netinet/in.h for them, and in-kernel code already does.
+-DLS
YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>@oss.sgi.com on
02/04/2004 03:37:39 AM
Sent by: netdev-bounce@oss.sgi.com
To: davem@redhat.com
cc: yoshfuji@linux-ipv6.org, netdev@oss.sgi.com
Subject: [PATCH] IPV6: note on shared socket options
Hello.
There're several socket options for multicast
shared between IPv4 and IPv6.
Add a note that some range is already used for them.
(Alternatevely, we could define other names like this:
#define IPV6_MCAST_JOIN_GROUP MCAST_JOIN_GROUP
#define IPV6_MCAST_BLOCK_SOURCE MCAST_BLOCK_SOURCE
/* bla, bla ... */
)
===== include/linux/in6.h 1.5 vs edited =====
--- 1.5/include/linux/in6.h Fri Mar 21 14:23:30 2003
+++ edited/include/linux/in6.h Wed Feb 4 20:30:47 2004
@@ -183,5 +183,17 @@
#define IPV6_IPSEC_POLICY 34
#define IPV6_XFRM_POLICY 35
+/*
+ * Multicast:
+ * Following socket options are shared between IPv4 and IPv6.
+ *
+ * MCAST_JOIN_GROUP 42
+ * MCAST_BLOCK_SOURCE 43
+ * MCAST_UNBLOCK_SOURCE 44
+ * MCAST_LEAVE_GROUP 45
+ * MCAST_JOIN_SOURCE_GROUP 46
+ * MCAST_LEAVE_SOURCE_GROUP 47
+ * MCAST_MSFILTER 48
+ */
#endif
--
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
[-- Attachment #2: Type: text/html, Size: 2032 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] IPV6: note on shared socket options
2004-02-04 21:49 ` David Stevens
@ 2004-02-05 2:09 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-05 4:02 ` David Stevens
2004-02-05 6:25 ` Pekka Savola
1 sibling, 1 reply; 6+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2004-02-05 2:09 UTC (permalink / raw)
To: dlstevens; +Cc: davem, netdev
In article <OF2F9C078B.064A8A19-ON87256E30.0077B005-88256E30.0077AF76@us.ibm.com> (at Wed, 4 Feb 2004 13:49:51 -0800), David Stevens <dlstevens@us.ibm.com> says:
> These are defined by draft-ietf-magma-msf-api-03.txt to be in
> netinet/in.h (no place else). What's the advantage of adding another
> copy in in6.h (which currently isn't used by anything)? Portable user apps
> must include netinet/in.h for them, and in-kernel code already does.
(I assume you're talking about the "alternatives.")
Kernel do not use netinet/*.h.
My main point is, do not let people (or myself) forget reserved
(or used) range. So, it is enough for me to add a comment on that.
Well, I really do not think that the name of MCAST_xxx is good.
Numeric assignment of "MCAST_xxx" functionalities
is only required to be unique in that level in theory
since we put MCAST_xxx at network level (IPPROTO_{IP,IPV6} for now).
However, they are share just because of the name.
Anyway, what I want to add is some small note on shared range.
Thanks.
--
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] IPV6: note on shared socket options
2004-02-05 2:09 ` YOSHIFUJI Hideaki / 吉藤英明
@ 2004-02-05 4:02 ` David Stevens
0 siblings, 0 replies; 6+ messages in thread
From: David Stevens @ 2004-02-05 4:02 UTC (permalink / raw)
To: YOSHIFUJI Hideaki / 吉藤英明; +Cc: davem, netdev
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
I see what you mean now; I agree. I'm not sure all of the other
socket options for each of v4 and v6 appear in a single file,
either; they definitely aren't all grouped so you can tell they come
from the same numeric namespace. So, picking new numbers
requires some detective work, but every little bit helps. :-)
+-DLS
[-- Attachment #2: Type: text/html, Size: 383 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] IPV6: note on shared socket options
2004-02-04 21:49 ` David Stevens
2004-02-05 2:09 ` YOSHIFUJI Hideaki / 吉藤英明
@ 2004-02-05 6:25 ` Pekka Savola
1 sibling, 0 replies; 6+ messages in thread
From: Pekka Savola @ 2004-02-05 6:25 UTC (permalink / raw)
To: David Stevens
Cc: YOSHIFUJI Hideaki / 吉藤英明, davem,
netdev
On Wed, 4 Feb 2004, David Stevens wrote:
> Yoshifuji-san,
> These are defined by draft-ietf-magma-msf-api-03.txt to be in
> netinet/in.h (no place else). What's the advantage of adding another
> copy in in6.h (which currently isn't used by anything)? Portable user apps
> must include netinet/in.h for them, and in-kernel code already does.
FWIW, this is already RFC 3678, so it might make sense to check
whether there have been changes since the draft version implemented.
> YOSHIFUJI Hideaki / ^[$B5HF#1QL@^[(B <yoshfuji@linux-ipv6.org>@oss.sgi.com on
> 02/04/2004 03:37:39 AM
>
> Sent by: netdev-bounce@oss.sgi.com
>
>
> To: davem@redhat.com
> cc: yoshfuji@linux-ipv6.org, netdev@oss.sgi.com
> Subject: [PATCH] IPV6: note on shared socket options
>
>
>
> Hello.
>
> There're several socket options for multicast
> shared between IPv4 and IPv6.
> Add a note that some range is already used for them.
>
> (Alternatevely, we could define other names like this:
> #define IPV6_MCAST_JOIN_GROUP MCAST_JOIN_GROUP
> #define IPV6_MCAST_BLOCK_SOURCE MCAST_BLOCK_SOURCE
> /* bla, bla ... */
> )
>
> ===== include/linux/in6.h 1.5 vs edited =====
> --- 1.5/include/linux/in6.h Fri Mar 21 14:23:30 2003
> +++ edited/include/linux/in6.h Wed Feb 4 20:30:47 2004
> @@ -183,5 +183,17 @@
> #define IPV6_IPSEC_POLICY 34
> #define IPV6_XFRM_POLICY 35
>
> +/*
> + * Multicast:
> + * Following socket options are shared between IPv4 and IPv6.
> + *
> + * MCAST_JOIN_GROUP 42
> + * MCAST_BLOCK_SOURCE 43
> + * MCAST_UNBLOCK_SOURCE 44
> + * MCAST_LEAVE_GROUP 45
> + * MCAST_JOIN_SOURCE_GROUP 46
> + * MCAST_LEAVE_SOURCE_GROUP 47
> + * MCAST_MSFILTER 48
> + */
>
> #endif
>
> --
> Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
> GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
>
--
Pekka Savola "You each name yourselves king, yet the
Netcore Oy kingdom bleeds."
Systems. Networks. Security. -- George R.R. Martin: A Clash of Kings
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] IPV6: note on shared socket options
2004-02-04 11:37 [PATCH] IPV6: note on shared socket options YOSHIFUJI Hideaki / 吉藤英明
2004-02-04 21:49 ` David Stevens
@ 2004-02-05 7:21 ` David S. Miller
1 sibling, 0 replies; 6+ messages in thread
From: David S. Miller @ 2004-02-05 7:21 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
On Wed, 04 Feb 2004 20:37:39 +0900 (JST)
YOSHIFUJI Hideaki / ^[$B5HF#1QL@^[(B <yoshfuji@linux-ipv6.org> wrote:
> There're several socket options for multicast
> shared between IPv4 and IPv6.
> Add a note that some range is already used for them.
Applied, thanks Yoshfuji.
As others noted, this in kernel internal headers, our own namespace,
and it's documentation so it's fine.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-02-05 7:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-04 11:37 [PATCH] IPV6: note on shared socket options YOSHIFUJI Hideaki / 吉藤英明
2004-02-04 21:49 ` David Stevens
2004-02-05 2:09 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-05 4:02 ` David Stevens
2004-02-05 6:25 ` Pekka Savola
2004-02-05 7:21 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).