From: "David S. Miller" <davem@redhat.com>
To: "Mika Penttilä" <mika.penttila@kolumbus.fi>
Cc: kazunori@miyazawa.org, yoshfuji@linux-ipv6.org,
netdev@oss.sgi.com, usagi-core@linux-ipv6.org
Subject: Re: [PATCH][IPV6][NDISC] unify ipv6 output routine
Date: Fri, 6 Feb 2004 19:48:44 -0800 [thread overview]
Message-ID: <20040206194844.42bebb59.davem@redhat.com> (raw)
In-Reply-To: <4023D6FB.9010909@kolumbus.fi>
On Fri, 06 Feb 2004 20:03:39 +0200
Mika Penttilä <mika.penttila@kolumbus.fi> wrote:
> >Yoshifuji-san and I send the patch which unifies IPv6 output routine and remove
> >RTF_NDISC again. It resolves an issue of IPv6 IPsec with neighbor discovery
> >without a flag.
>
> You break multicast replies, see what ndisc_build_ll_hdr() does...
That's right, and compiler should have warned about ndisc_build_ll_hdr()
(a static function in ndisc.c) since it was no longer referenced after
applying the patch, which would be a clue that something was wrong :-)
next prev parent reply other threads:[~2004-02-07 3:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-06 17:32 [PATCH][IPV6][NDISC] unify ipv6 output routine Kazunori Miyazawa
2004-02-06 18:03 ` Mika Penttilä
2004-02-07 3:48 ` David S. Miller [this message]
2004-02-07 4:14 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-07 4:33 ` Kazunori Miyazawa
2004-02-08 21:08 ` David S. Miller
2004-02-08 21:26 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-07 8:40 ` Mika Penttilä
2004-02-07 10:28 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-07 10:41 ` Mika Penttilä
2004-02-07 10:45 ` Mika Penttilä
2004-02-07 11:29 ` (usagi-core 17380) " YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040206194844.42bebb59.davem@redhat.com \
--to=davem@redhat.com \
--cc=kazunori@miyazawa.org \
--cc=mika.penttila@kolumbus.fi \
--cc=netdev@oss.sgi.com \
--cc=usagi-core@linux-ipv6.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).